pkg/datapath: Remove defunct --single-cluster-route flag
#29221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `single-cluster-route` flag. Contrary to it's description, it never [1] installed a cluster-wide route for `cilium_host`. Instead, it installed a route for the local alloc CIDR (aka local PodCIDR), virtually identical to the (enabled by default) `enable-local-node-route`. The only difference being that `single-cluster-route` sets the MTU. This means that the flag (which has not been referenced anywhere in the last four years) likely never worked as described. Marco Iorio recently tested the flag and found that the flag (when enabled) breaks node-to-pod and nodeport traffic. In addition, since the route conflicts with the local node route, we also found that the "single cluster route" was in fact overwritten by the "local node route". The only other effect the flag has is that it disables per-node routes, but those are needed for node-to-pod traffic. Removal has already been discussed two years ago [1]. Given that the flag has remained broken ever since and there have not been any bug reports at all, it is assumed that no one is actually using it. It is also not documented anywhere outside of the cmdref. Therefore, it is removed without prior deprecation. [1] cilium#18426 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added
sig/datapath
gandro
commented
Nov 16, 2023
maintainer-s-little-helper
bot
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
single-cluster-routeflag. Contrary to it's description, it never installed a cluster-wide route forcilium_host. Instead, it installed a route for the local alloc CIDR (aka local PodCIDR), virtually identical to the (enabled by default)enable-local-node-route. The only difference being thatsingle-cluster-routesets the MTU. This means that the flag (which has not been referenced anywhere in the last four years) likely never worked as described.Marco Iorio (@giorio94) recently tested the flag and found that the flag (when enabled) breaks node-to-pod and nodeport traffic. In addition, since the route conflicts with the local node route, we also found that the "single cluster route" was in fact overwritten by the "local node route". The only other effect the flag has is that it disables per-node routes, but those are needed for node-to-pod traffic.
Removal has already been discussed two years ago. Given that the flag has remained broken ever since and there have not been any bug reports at all, it is assumed that no one is actually using it. It is also not documented anywhere outside of the cmdref. Therefore, it is removed without prior deprecation.