Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.13: ariane: Run ci-ipsec-upgrade when testing backports #29227

Merged
merged 2 commits into from
Nov 24, 2023
Merged

v1.13: ariane: Run ci-ipsec-upgrade when testing backports #29227

merged 2 commits into from
Nov 24, 2023

Conversation

brb
Copy link
Member

@brb brb commented Nov 16, 2023

No description provided.

@brb brb added kind/backports This PR provides functionality previously merged into master. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. labels Nov 16, 2023
@brb
Copy link
Member Author

brb commented Nov 16, 2023

/test-backport-1.13

@brb brb changed the title ariane: Run ci-ipsec-upgrade when testing backports v1.13: ariane: Run ci-ipsec-upgrade when testing backports Nov 16, 2023
@brb brb mentioned this pull request Nov 22, 2023
Merged
1 task
@brb
Copy link
Member Author

brb commented Nov 22, 2023

/ci-ipsec-upgrade

@brb
ariane: Run ci-ipsec-upgrade when testing backports
0a6c27c 
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/v1.13-ci-ipsec-upgrade branch from d8a286d to 81c06ec Compare November 22, 2023 13:18
@brb
Copy link
Member Author

brb commented Nov 22, 2023

/ci-ipsec-upgrade

@brb
ci-ipsec-upgrade: Disable IPv6
733c0e0 
Previously, all upgrade tests were failing when IPv6 was enabled. Gray
pointed out:

    It looks like this issue:
    #23461 which was fixed by
    75216d3.
    The symptom I noticed was unexpected masquerading, leading to
    further kfree_skb_reason(SKB_DROP_REASON_NO_SOCKET) and TCP reset.

Suggested-by: Gray Liang <gray.liang@isovalent.com>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/v1.13-ci-ipsec-upgrade branch from 81c06ec to 733c0e0 Compare November 22, 2023 13:47
@brb
Copy link
Member Author

brb commented Nov 22, 2023

/ci-ipsec-upgrade

@brb brb marked this pull request as ready for review November 22, 2023 14:16
@brb brb requested review from a team as code owners November 22, 2023 14:16
qmonnet
qmonnet approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First commit looks good. Second commit looks correct assuming we're OK with disabling IPv6 in CI for these tests.

@qmonnet qmonnet mentioned this pull request Nov 23, 2023
Merged
4 tasks
@lmb
Copy link
Contributor

lmb commented Nov 23, 2023

/test-backport-1.13

@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 24, 2023
@lmb
Copy link
Contributor

lmb commented Nov 24, 2023

/test-1.21-4.19

@pchaigno pchaigno merged commit 60343fe into v1.13 Nov 24, 2023
136 of 137 checks passed
@pchaigno pchaigno deleted the pr/brb/v1.13-ci-ipsec-upgrade branch November 24, 2023 11:41
@nebril nebril mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmb lmb lmb approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

@jschwinger233 jschwinger233 jschwinger233 approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@brb @lmb @nbusseneau @jschwinger233 @qmonnet @pchaigno