workflows: move cilium_cli_version definition to set-env-variables action #29237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jibi
added
area/CI
jibi
force-pushed
the
pr/jibi/move-cli-version-to-env-var
branch
from
3369d03
to
0cf809b
Compare
jibi
force-pushed
the
pr/jibi/move-cli-version-to-env-var
branch
from
90199e4
to
0a9da3a
Compare
tklauser
requested changes
Nov 17, 2023
jibi
force-pushed
the
pr/jibi/move-cli-version-to-env-var
branch
3 times, most recently
from
395f3f3
to
e77e96d
Compare
|
/test |
tklauser
approved these changes
Nov 17, 2023
|
example of successful run https://github.com/cilium/cilium/actions/runs/6904072712 |
jibi
force-pushed
the
pr/jibi/move-cli-version-to-env-var
branch
from
e77e96d
to
3825539
Compare
|
i'm picking up this pull request. excited to resolve all these conflicts 🥰 |
michi-covalent
force-pushed
the
pr/jibi/move-cli-version-to-env-var
branch
from
3825539
to
3294907
Compare
michi-covalent
approved these changes
Nov 20, 2023
michi-covalent
force-pushed
the
pr/jibi/move-cli-version-to-env-var
branch
from
3294907
to
e44562f
Compare
…tion Co-authored-by: Tobias Klauser <tobias@isovalent.com> Signed-off-by: Gilberto Bertin <jibi@cilium.io>
Assign .github/renovate.json5 to @cilium/github-sec and @cilium/ci-structure. Signed-off-by: Gilberto Bertin <jibi@cilium.io> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/jibi/move-cli-version-to-env-var
branch
from
46bd7d4
to
a8ae167
Compare
|
/test |
|
these failures are expected. the change in .github/actions/set-env-variables/action.yml needs to be in the main branch:
|
joestringer
approved these changes
Nov 20, 2023
|
manually setting ready-to-merge label since these failure are expected 🚀 🙏 |
michi-covalent
added
the
ready-to-merge
sayboras
approved these changes
Nov 20, 2023
michi-covalent
added a commit
that referenced
this pull request
Nov 22, 2023
Define CILIUM_CLI_RELEASE_REPO environment variable in set-env-variables action, and use that to specify the repository parameter for cilium-cli action to make it easier for downstream projects to override it. Ref: #29237 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
maintainer-s-little-helper
bot
removed
the
ready-to-merge
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 23, 2023
Define CILIUM_CLI_RELEASE_REPO environment variable in set-env-variables action, and use that to specify the repository parameter for cilium-cli action to make it easier for downstream projects to override it. Ref: #29237 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
sayboras
pushed a commit
that referenced
this pull request
Nov 25, 2023
[ upstream commit 3f694f8 ] Define CILIUM_CLI_RELEASE_REPO environment variable in set-env-variables action, and use that to specify the repository parameter for cilium-cli action to make it easier for downstream projects to override it. Ref: #29237 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com> Signed-off-by: Tam Mach <tam.mach@isovalent.com>
pjablonski123
pushed a commit
to pjablonski123/cilium
that referenced
this pull request
Dec 15, 2023
Define CILIUM_CLI_RELEASE_REPO environment variable in set-env-variables action, and use that to specify the repository parameter for cilium-cli action to make it easier for downstream projects to override it. Ref: cilium#29237 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
pjablonski123
pushed a commit
to pjablonski123/cilium
that referenced
this pull request
Dec 15, 2023
Looks like cilium#29237 missed tests-e2e-upgrade.yaml. Fixes: 42e1a4a ("workflows: move cilium_cli_version definition to set-env-variables action") Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
jibi
added
needs-backport/1.12
needs-backport/1.13
jibi
added
backport-pending/1.14
github-actions
bot
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.