Use Resource[T] to implement CEP and CES watchers #29249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pippolo84
added
sig/k8s
This comment was marked as outdated.
This comment was marked as outdated.
pippolo84
force-pushed
the
pr/pippolo84/migrate-cilium-endpoint-resource
branch
from
8384ccc
to
9fd0387
Compare
pippolo84
force-pushed
the
pr/pippolo84/migrate-cilium-endpoint-resource
branch
2 times, most recently
from
d7ed88a
to
715cb9e
Compare
pippolo84
removed
the
release-blocker/1.15
This was referenced Nov 28, 2023
This comment was marked as outdated.
This comment was marked as outdated.
pippolo84
added
the
dont-merge/blocked
pippolo84
force-pushed
the
pr/pippolo84/migrate-cilium-endpoint-resource
branch
from
715cb9e
to
8ea327b
Compare
aanm
added
dont-merge/wait-until-release
pippolo84
added
release-blocker/1.15
pippolo84
force-pushed
the
pr/pippolo84/migrate-cilium-endpoint-resource
branch
from
8ea327b
to
fddc505
Compare
pippolo84
force-pushed
the
pr/pippolo84/migrate-cilium-endpoint-resource
branch
from
fddc505
to
0405ef0
Compare
joamaki
approved these changes
Dec 22, 2023
pippolo84
force-pushed
the
pr/pippolo84/migrate-cilium-endpoint-resource
branch
from
0405ef0
to
56b468e
Compare
|
/test |
The CEP and CES stores getter was originally meant for Hubble, but it is not used anymore, so it is possible to clean it up. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Use a releasable Resource[CiliumSlimEndpoint] to refactor the agent CEP watcher. Like the previous implementation, the underlying informer is stopped as soon as the subscription to the events stream is canceled. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Use a releasable Resource[CiliumEndpointSlice] to refactor the agent CES watcher. Like the previous implementation, the underlying informer is stopped as soon as the subscription to the events stream is canceled. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
CiliumEndpoint and CiliumEndpointSlice resources are backed by a releasable resource. To allow stopping the underlying informer when it is not needed anymore, the cleanup routine should release the reference to the store after collecting the stale CEPs. Also, this keeps the CiliumEndpoint cleanup routine fully working even when the agent is configured to use an external key-value store. In that scenario, the routine starts the k8s informer to list the CEPs or CESs and, once all the stale CEPs have been collected, releases the resource to stop the informer. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
force-pushed
the
pr/pippolo84/migrate-cilium-endpoint-resource
branch
from
56b468e
to
62b287c
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
👋 if this is still a 1.15 release blocker, it will also need a 1.15 backport. Adding the label, please shout if it's no longer needded. |
julianwiedmann
added
the
needs-backport/1.15
jibi
added
backport-pending/1.15
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in v1.15.0-rc.1
giorio94
added
backport-done/1.15
maintainer-s-little-helper
bot
moved this from Backport pending to v1.15
to Backport done to v1.15
in v1.15.0-rc.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Resource[T] to implement the CiliumEndpoint and CiliumEndpointSlice k8s watchers. This removes the additional informers previously used, reducing the queries to the kube-apiserver and reducing the memory needed for the additional local caches.
Please refer to the individual commits for further details.
Depends on
#29414,#29243,#29244and#29246Related: #28159