-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add merge_group trigger #29276
Merged
Merged
CI: Add merge_group trigger #29276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Nov 20, 2023
brlbil
added
area/CI
Continuous Integration testing issue or flake
release-note/ci
This PR makes changes to the CI.
labels
Nov 20, 2023
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
labels
Nov 20, 2023
brlbil
added
needs-backport/1.12
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
labels
Nov 21, 2023
This commit adds merge_group trigger to workflows that have required checks. "Installation and Conformance Test" in smoke-test-ipv6 workflow is renamed as "Installation and Conformance Test (ipv6)" to distinguish the check from the one that is in smoke-test workflow. This way this check can also be added to required checks without mixup. Signed-off-by: Birol Bilgin <birol@cilium.io>
brlbil
force-pushed
the
pr/brlbil/ci-add-merge-group
branch
from
November 21, 2023 09:30
2e3f8b7
to
4418888
Compare
/test |
aanm
approved these changes
Nov 21, 2023
brlbil
removed
needs-backport/1.12
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
labels
Nov 21, 2023
brlbil
requested review from
viktor-kurchenko
and removed request for
nbusseneau
November 21, 2023 14:21
viktor-kurchenko
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds merge_group trigger to workflows that have required checks.
"Installation and Conformance Test" in smoke-test-ipv6 workflow is renamed as "Installation and Conformance Test (ipv6)" to distinguish the check from the one that is in smoke-test workflow.
This way this check can also be added to required checks without mixup.