Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hubble-relay: Add support for peers joining during requests #29326

Merged
merged 1 commit into from
Dec 1, 2023
Merged

hubble-relay: Add support for peers joining during requests #29326

merged 1 commit into from
Dec 1, 2023

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Nov 22, 2023 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin

With this change, if the request is in follow mode, we periodically re-list peers and send the request to newly joined or reconnected peers.

Fixes: #12833

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 22, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 22, 2023
@glrf glrf force-pushed the hubble-relay/long-requests branch 3 times, most recently from 8194af9 to ece7900 Compare November 22, 2023 15:14
@glrf glrf marked this pull request as ready for review November 22, 2023 15:47
@glrf glrf requested a review from a team as a code owner November 22, 2023 15:47
@michi-covalent
Copy link
Contributor

might need to pull in @rolinh or @kaworu here, i'm not too familiar with this logic 🚀🙏

@rolinh rolinh self-requested a review November 23, 2023 14:59
@rolinh rolinh self-assigned this Nov 23, 2023
@michi-covalent michi-covalent added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Nov 23, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 23, 2023
@kaworu kaworu self-requested a review November 27, 2023 09:06
@aanm
Copy link
Member

aanm commented Nov 27, 2023

/test

kaworu
kaworu requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor suggestion, but overall LGTM!

pkg/hubble/relay/observer/observer.go Outdated Show resolved Hide resolved
pkg/hubble/relay/observer/server.go Outdated Show resolved Hide resolved
pkg/hubble/relay/observer/server_test.go Show resolved Hide resolved
@glrf glrf force-pushed the hubble-relay/long-requests branch 2 times, most recently from 1f06e41 to 5f76668 Compare November 28, 2023 14:37
@glrf glrf requested a review from kaworu November 28, 2023 16:02
@rolinh rolinh added the sig/hubble Impacts hubble server or relay label Nov 29, 2023
rolinh
rolinh approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks for tackling this relay-old issue! lgtm, nice work!

michi-covalent
michi-covalent approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i trust robin's review.

@aanm
Copy link
Member

aanm commented Nov 29, 2023

/test

@glrf
hubble-relay: Add support for peers joining during requests
fad4840 
With this change, if the request is in follow mode, we periodically
re-list peers and send the request to newly joined or reconnected
peers.

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
@glrf glrf force-pushed the hubble-relay/long-requests branch from 5f76668 to fad4840 Compare December 1, 2023 08:27
@rolinh
Copy link
Member

rolinh commented Dec 1, 2023

/test

@aanm aanm enabled auto-merge December 1, 2023 10:22
@aanm aanm added this pull request to the merge queue Dec 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 1, 2023
Merged via the queue into cilium:main with commit 9a5998f Dec 1, 2023
59 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@rolinh rolinh rolinh approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees

@rolinh rolinh

Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/hubble Impacts hubble server or relay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hubble-relay: handle peers joining during long running requests
5 participants
@glrf @michi-covalent @aanm @rolinh @kaworu