lbipam: Fix off-by-one error in rangeFromPrefix #29425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
YutaroHayakawa
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
YutaroHayakawa
force-pushed
the
fix-29410
branch
from
b46c6c0
to
9845e2a
Compare
2 tasks
|
/test |
YutaroHayakawa
force-pushed
the
fix-29410
branch
from
9845e2a
to
2d85649
Compare
|
Rebased on the latest main. |
|
/test |
|
Looks like this needs a rebase to pull in a2694fc to fix the failing runtime tests. |
There's an off-by-one error in rangeFromPrefix that miscalculates the end of the allocatable IP range when the prefix length is not byte-aligned. We couldn't catch this bug with the test because the expected value in the test was wrong. netipx package provides a convenient function netipx.PrefixLastIP which does what we want. Rely on that instead of calculating it by ourselves. Fixes: cilium#29410 Fixes: 32feef5 Fixes: 27322f3 Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
force-pushed
the
fix-29410
branch
from
2d85649
to
664342a
Compare
|
Thanks! Rebased... |
|
/test |
|
Hmm the image build failure is very mysterious (thanks Tobias for retrying). Now it's succeeding, so it's an intermittent error. Sort of rate limiting I guess... |
|
Retriggered all tests failed with timeout waiting for the image build. |
|
Cilium E2E: #29476 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an off-by-one error in rangeFromPrefix that miscalculates the end of the allocatable IP range when the prefix length is not byte-aligned. We couldn't catch this bug with the test because the expected value in the test was wrong.
netipx package provides a convenient function netipx.PrefixLastIP which does what we want. Rely on that instead of calculating it by ourselves.
Fixes: #29410
Fixes: 32feef5
Fixes: 27322f3