[v1.14] bgpv1: Fix BGP component tests using the same VirtualRouter config #29453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As some of the BGP component tests mutate the VirtualRouter config, we need to make sure that mutated config is not used by the following tests. That was the case before this fix, as multiple tests are using the same baseBGPPolicy. Now each test creates a deep copy of the base config, which is fine to mutate within the test. This change also ensures that fixture.config.policy always contains the most up-to-date policy. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
rastislavs
added
kind/backports
|
/test-backport-1.14 |
harsimran-pabla
approved these changes
Nov 28, 2023
youngnick
approved these changes
Nov 29, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an author's backport of #28420 potentially fixing the CI issue #28415