plugins/cilium-cni: Install loopback atomically #29462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If copying of the loopback binary is interrupted, then a truncated
version will exist on the node. The node can't recover from this state
even if the pod is restarted because install-plugin.sh won't overwrite
the existing loopback file.
To fix, install loopback atomically using a cp + mv.
This change also removes the unnecessary deletion of "${BIN_NAME}.new".
This is a no-op because the temporary copy destination is prefixed with
a dot: ".${BIN_NAME}.new".
Signed-off-by: Akhil Velagapudi <4@4khil.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
youngnick
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
|
Any chance this can be back-ported to v1.12+ as it's a bug fix? We actually encountered this issue in v1.12. |
aanm
added
release-note/bug
aanm
approved these changes
Nov 29, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
@akhilles According the backports criteria, 1.12 would security related bug fixes. We can mark it for 1.14. |
aanm
added
affects/v1.12
10 tasks
nbusseneau
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.5
github-actions
bot
removed
the
backport-pending/1.14
github-actions
bot
added
the
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If copying of the loopback binary is interrupted, then a truncated version will exist on the node. The node can't recover from this state even if the pod is restarted because install-plugin.sh won't overwrite the existing loopback file.
To fix, install loopback atomically using a cp + mv.
This change also removes the unnecessary deletion of "${BIN_NAME}.new". This is a no-op because the temporary copy destination is prefixed with a dot: ".${BIN_NAME}.new".
Fixes: #29461