bgpv1: Use kube-system namespace by default for MD5 secret #29478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YutaroHayakawa
added
release-note/minor
YutaroHayakawa
requested review from
a team and
rastislavs
and removed request for
a team
rastislavs
reviewed
Nov 29, 2023
gandro
approved these changes
Nov 29, 2023
|
/test |
YutaroHayakawa
force-pushed
the
bgp-md5-password-namespace-default
branch
from
2d65875
to
19b2a1f
Compare
|
Rebased on top of the main to pull-in a2694fc |
|
Hmm, Quay looks under the weather... Let me retry. |
Currently, BGP Control Plane uses cilium-bgp-secrets namespace by default to fetch MD5 password authentication. Also, if not specified, it creates a new namespace by default. However, the rest of the cilium-related secrets such as cilium-ca, hubble certificates, or clustermesh certificates are in kube-system namespace. So, having a new namespace is inconsistent with rest of the system, and also inconvenient since users need to manage one more namespace. This commit addresses the issue by changing the default value of `bgpControlPlane.secretNamespace.name` to `kube-system` and `bgpControlPlane.secretNamespace.create` to `false`. Users can always change the namespace if they wish to have an isolation. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
force-pushed
the
bgp-md5-password-namespace-default
branch
from
19b2a1f
to
6b69064
Compare
|
Forgot to update cmdref 🤦 Force pushed. |
|
/test |
youngnick
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
LGTM, nice work.
For everyone's info: the cilium-secrets namespace is a bit of a different use case, in that it's a place where Secrets relevant to Ingress or Gateway API get synced to, which means that the Agent doesn't need whole-cluster Secret read access (which is way bigger than what it needs).
So, that namespace, although named generically, really needs to only be used for automatically-synced Secrets (which is only used in Ingress and Gateway API at the moment).
|
ci-clustermesh: #28622 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, BGP Control Plane uses cilium-bgp-secrets namespace by default to fetch MD5 password authentication. Also, if not specified, it creates a new namespace by default.
However, the rest of the cilium-related secrets such as cilium-ca, hubble certificates, or clustermesh certificates are in kube-system namespace. So, having a new namespace is inconsistent with rest of the system, and also inconvenient since users need to manage one more namespace.
This commit addresses the issue by changing the default value of
bgpControlPlane.secretNamespace.nametokube-systemandbgpControlPlane.secretNamespace.createtofalse. Users can always change the namespace if they wish to have an isolation.I put
release-note/minorbecause this BGP MD5 feature is only released inv1.15-prereleases.