ci: fix dns issue when pulling cilium-docker-plugin in ci-runtime #29502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
kind/bug/CI
mhofstetter
force-pushed
the
pr/mhofstetter/runtime-dns
branch
2 times, most recently
from
c6464a9
to
c02a0e3
Compare
mhofstetter
changed the title
It seems that even though we're setting the nameserver at the top of `/etc/resolv.conf`, in some cases docker still uses 127.0.0.53 to resolve names while pulling the cilium docker plugin in the ci-runtime test. It seems as docker tries to use nameserver information from `systemd-resolved`. Therefore, this commit tries to force docker to use the nameserver 1.1.1.1, by removing the resolv.conf symlink, deleting the resolv.conf from systemd-resolved and restarting the docker service after applying the changes. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/runtime-dns
branch
from
c02a0e3
to
52b9bab
Compare
|
/test |
brb
approved these changes
Nov 30, 2023
viktor-kurchenko
approved these changes
Dec 1, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
mhofstetter
added
the
needs-backport/1.14
10 tasks
giorio94
added
backport-pending/1.14
github-actions
bot
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that even though we're setting the nameserver at the top of
/etc/resolv.conf(#29455), in some cases docker still uses 127.0.0.53 to resolve names while pulling the cilium docker plugin in the ci-runtime test (e.g. https://github.com/cilium/cilium/actions/runs/7044583579/job/19172666548).In one specific test-run even if
etc/resolv.confonly contains nameserver 1.1.1.1.It seems as docker tries to use nameserver information from
systemd-resolved.Therefore, this commit tries to force docker to use the nameserver 1.1.1.1, by removing the resolv.conf symlink, deleting the resolv.conf from systemd-resolved and restarting the docker service after applying the changes.
Follow up of #29455