Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: Add missing SA automount configuration #29511

Merged
merged 4 commits into from
Dec 6, 2023
Merged

helm: Add missing SA automount configuration #29511

merged 4 commits into from
Dec 6, 2023

Conversation

ayuspin
Copy link
Contributor

@ayuspin ayuspin commented Nov 30, 2023

Follow-up to #23441 to add missing automountServiceAccountToken, extraVolumes and extraVolumeMounts

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 30, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 30, 2023
@ayuspin ayuspin marked this pull request as ready for review December 5, 2023 15:18
@ayuspin ayuspin requested review from a team as code owners December 5, 2023 15:18
@gandro
Copy link
Member

gandro commented Dec 5, 2023

Thanks for the PR. Please note that the helm README.md also needs to be re-generated: make -C install/kubernetes

@ayuspin
Copy link
Contributor Author

ayuspin commented Dec 5, 2023

@gandro thank you for looking into this, I regenerated helm README.md as suggested

@sayboras sayboras added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Dec 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 6, 2023
@sayboras sayboras added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 6, 2023
@sayboras sayboras added area/helm Impacts helm charts and user deployment experience dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 6, 2023
@ayuspin @sayboras
helm: Add extraVolumeMounts to cilium-monitor and clean-cilium-state
7cb2d8a 
Signed-off-by: Andrii Iuspin <yuspin@gmail.com>
@ayuspin @sayboras
helm: Add automount related fields to preflight
78ca29d 
This commit is to add automountServiceAccountToken, extraVolumes and
extraVolumeMounts field to preflight workload.

Signed-off-by: Andrii Iuspin <yuspin@gmail.com>
@ayuspin @sayboras
helm: Add extraVolumeMounts to etcd-init and etcd
aed6a8e 
Signed-off-by: Andrii Iuspin <yuspin@gmail.com>
@ayuspin @sayboras
helm: Add extraVolumes and extraVolumeMounts to hubble-relay
47ef846 
Signed-off-by: Andrii Iuspin <yuspin@gmail.com>
@sayboras
Copy link
Member

sayboras commented Dec 6, 2023

/test

sayboras
sayboras approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@gandro gandro removed the request for review from youngnick December 6, 2023 09:04
@gandro gandro added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 6, 2023
@sayboras sayboras mentioned this pull request Dec 7, 2023
Merged
3 tasks
@sayboras sayboras added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Dec 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.5 Dec 7, 2023
@sayboras sayboras mentioned this pull request Dec 7, 2023
Merged
3 tasks
@sayboras sayboras added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Dec 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.10 Dec 7, 2023
@sayboras sayboras mentioned this pull request Dec 7, 2023
Merged
3 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.12 in 1.12.17 Dec 7, 2023
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Dec 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.5 Dec 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport done to v1.14 in 1.14.5 Dec 7, 2023
@github-actions github-actions bot added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Dec 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.14 in 1.14.5 Dec 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.13 in 1.13.10 Dec 8, 2023
@github-actions github-actions bot added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Dec 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.13 in 1.13.10 Dec 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.12 in 1.12.17 Dec 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.12 in 1.12.17 Dec 8, 2023
This was referenced Dec 11, 2023
Merged
Merged
Merged
@joestringer joestringer mentioned this pull request Dec 14, 2023
Merged
@ayuspin ayuspin mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.12.17
Backport done to v1.12
1.13.10
Backport done to v1.13
1.14.5
Backport done to v1.14
cilium v1.12.17
Status: Released
cilium v1.13.10
Status: Released
cilium v1.14.5
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ayuspin @gandro @sayboras