Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Modify BGP MD5 password with Helm default change #29527

Merged
merged 1 commit into from
Dec 6, 2023
Merged

docs: Modify BGP MD5 password with Helm default change #29527

merged 1 commit into from
Dec 6, 2023

Conversation

YutaroHayakawa
Copy link
Member

d199a07 introduced Helm default value change for BGP MD5. Adjust document to reflect the change. Also added an additional guidance for changing the default.

docs: Modify BGP MD5 password with Helm default change

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 1, 2023
@YutaroHayakawa YutaroHayakawa added the release-note/misc This PR makes changes that have no direct user impact. label Dec 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 1, 2023
@YutaroHayakawa YutaroHayakawa marked this pull request as ready for review December 1, 2023 08:08
@YutaroHayakawa YutaroHayakawa requested review from a team as code owners December 1, 2023 08:08
rastislavs
rastislavs approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rastislavs
Copy link
Contributor

/test

learnitall
learnitall requested changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, but otherwise LGTM

Documentation/network/bgp-control-plane.rst Outdated Show resolved Hide resolved
@rastislavs rastislavs force-pushed the bgp-md5-password-namespace-default-doc branch from c637e57 to a6c67c7 Compare December 5, 2023 08:25
@rastislavs
Copy link
Contributor

/test

@rastislavs rastislavs added area/bgp area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. labels Dec 5, 2023
learnitall
learnitall approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@YutaroHayakawa @rastislavs
docs: Modify BGP MD5 password with Helm default change
41665ee 
d199a07 introduced Helm default value change for BGP MD5. Adjust
document to reflect the change. Also added an additional guidance for
changing the default.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Co-authored-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
@rastislavs rastislavs force-pushed the bgp-md5-password-namespace-default-doc branch from a6c67c7 to 41665ee Compare December 6, 2023 06:45
@rastislavs
Copy link
Contributor

/test

@rastislavs
Copy link
Contributor

rastislavs commented Dec 6, 2023 •
edited
Loading

ci-ipsec-e2e job seems to be stuck in the Expected state - as it is optional and not even related to this docs-only change, marking as ready to merge.

@rastislavs rastislavs added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 6, 2023
@ti-mo ti-mo merged commit 200a0f8 into main Dec 6, 2023
58 checks passed
@ti-mo ti-mo deleted the bgp-md5-password-namespace-default-doc branch December 6, 2023 13:59
@joestringer joestringer mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rastislavs rastislavs rastislavs approved these changes

@learnitall learnitall learnitall approved these changes

Assignees
No one assigned
Labels
area/bgp area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YutaroHayakawa @rastislavs @learnitall @ti-mo