Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: Ignore loadbalancer class for Gateway service #29547

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Dec 1, 2023

This is to align with Ingress implementation

Relates: #29327
Fixes: #28949

Co-authored-by: Marco Hofstetter marco.hofstetter@isovalent.com
Signed-off-by: Tam Mach tam.mach@cilium.io

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 1, 2023
@sayboras sayboras added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Dec 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 1, 2023
@sayboras sayboras added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Dec 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.5 Dec 1, 2023
@sayboras
Copy link
Member Author

sayboras commented Dec 1, 2023

/ci-gateway-api

sayboras and others added 2 commits December 1, 2023 23:21
This is to leverage the existing controllerutil package to ensure the
resources.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to align with Ingress implementation

Relates: cilium#29327
Fixes: cilium#28949

Co-authored-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
Copy link
Member Author

sayboras commented Dec 1, 2023

/ci-gatewayapi

@sayboras
Copy link
Member Author

sayboras commented Dec 1, 2023

/ci-gateway-api

@sayboras
Copy link
Member Author

sayboras commented Dec 1, 2023

/test

@sayboras sayboras marked this pull request as ready for review December 1, 2023 12:35
@sayboras sayboras requested a review from a team as a code owner December 1, 2023 12:35
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 4, 2023
@youngnick youngnick added this pull request to the merge queue Dec 4, 2023
Merged via the queue into cilium:main with commit 4f515fa Dec 4, 2023
61 checks passed
@sayboras sayboras deleted the tam/lb-class branch December 4, 2023 07:55
@nbusseneau nbusseneau mentioned this pull request Dec 5, 2023
10 tasks
@nbusseneau nbusseneau added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Dec 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.5 Dec 5, 2023
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Dec 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.14 in 1.14.5 Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
Status: Released
Development

Successfully merging this pull request may close these issues.

Gateway API controller overwriting Service.spec.loadBalancerClass if set
3 participants