Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: clean up some IPv4 header validations #29585

Merged
merged 2 commits into from
Dec 8, 2023
Merged

bpf: clean up some IPv4 header validations #29585

merged 2 commits into from
Dec 8, 2023

Conversation

julianwiedmann
Copy link
Member

ct_lookup4() and ipv4_load_l4_ports() currently each contain a call to revalidate_data(). Replace them by passing a validated IPv4 header as parameter.

@julianwiedmann
bpf: ipv4: avoid header revalidation in ipv4_load_l4_ports()
40d205c 
All callers have a validated IPv4 header, we just need to pipe it through.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: ct: avoid header revalidation in ct_lookup4()
23fac72 
All callers have a validated IPv4 header, we just need to pipe it through.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. kind/tech-debt Technical debt labels Dec 4, 2023
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann marked this pull request as ready for review December 4, 2023 08:57
@julianwiedmann julianwiedmann requested a review from a team as a code owner December 4, 2023 08:57
gentoo-root
gentoo-root approved these changes Dec 7, 2023
View reviewed changes
bpf/lib/conntrack.h Outdated Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Dec 7, 2023
@julianwiedmann julianwiedmann added this pull request to the merge queue Dec 8, 2023
Merged via the queue into cilium:main with commit 3951a17 Dec 8, 2023
62 checks passed
@julianwiedmann julianwiedmann deleted the 1.15-bpf-ct-lookup4 branch December 8, 2023 07:07
@joestringer joestringer mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentoo-root gentoo-root gentoo-root approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. kind/tech-debt Technical debt ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julianwiedmann @gentoo-root