bpf/Makefile: remove gen_compile_commands make target #29611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
Yup, this was here purely for convenience, didnt realize it would flag a linter. Feel free to removal. |
ldelossa
approved these changes
Dec 4, 2023
|
Spoke with @ti-mo out of band. |
The presence of the GitHub project URL for Bear got flagged in a GPL license check. Remove the bear URL from gen_compile_commands make target so the GPL license check can pass. Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
ldelossa
force-pushed
the
tb/bpf-remove-bear
branch
from
327a9e0
to
9b87497
Compare
ldelossa
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
ti-mo
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The presence of the GitHub project URL for Bear got flagged in a GPL license
check. Remove the gen_compile_commands make target as it simply resolves to
bear --make. It doesn't seem to be referenced by any GH workflows, so itcould be invoked by personal scripts/configuration instead.
@ldelossa Could you live with this?