fqdn: avoid converting from netip.Addr to net.IP and back
#29625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
kind/cleanup
|
/test |
fqdn.DNSCache keeps its IP addresses as netip.Addr internally already. The (*DNSCache).Lookup and (*DNSCache.LookupByRegex methods currently return a []net.IP and map[string][]net.IP but their callers directly convert the IPs in the return values to netip.Addr again. Avoid this back-and-forth conversion and let the methods return netip.Addr types directly. Signed-off-by: Tobias Klauser <tobias@cilium.io>
The last remaining users of KeepUniqueIPs were converted to use KeepUniqueAddrs. Remove the now unused function. Signed-off-by: Tobias Klauser <tobias@cilium.io>
SortedIPListsAreEqual no longer has any callers outside of pkg/ip. Inline the use into the only caller and avoid a second slice length comparision while at it. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/fqdn-netip-no-back-and-forth
branch
from
08942e7
to
f466edb
Compare
|
/test |
ti-mo
approved these changes
Dec 5, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
tklauser
added
the
needs-backport/1.14
giorio94
added
backport-pending/1.14
|
Dropped the backport labels based on #29863 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
(*DNSCache).Lookupand(*DNSCache).LookupByRegexto returnnetip.Addr. This avoids a back-and-forth conversion tonet.IPand allows to drop some now unused helper functions inpkg/ip.See commits for details.
Towards: #24246