Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codeowners: use new teams cilium/envoy & cilium/fqdn #29627

Merged
merged 1 commit into from
Dec 5, 2023
Merged

codeowners: use new teams cilium/envoy & cilium/fqdn #29627

merged 1 commit into from
Dec 5, 2023

Conversation

mhofstetter
Copy link
Member

@mhofstetter mhofstetter commented Dec 5, 2023 •
edited
Loading

This commit updates the codeownership for FQDN- & Envoy proxy related code with the new teams.

  • Core / Common -> cilium/proxy
  • FQDN Integration -> cilium/fqdn
  • Envoy Integration -> cilium/envoy

@mhofstetter mhofstetter added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels Dec 5, 2023
@mhofstetter mhofstetter requested a review from a team as a code owner December 5, 2023 11:35
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/codeowners-proxy branch from 8eb1f2b to 0425e5b Compare December 5, 2023 11:40
sayboras
sayboras approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and lgtm ✔️

@mhofstetter
codeowners: use new teams cilium/envoy & cilium/fqdn
60b08a6 
This commit updates the codeownership for FQDN- & Envoy proxy related
code with the new teams.

* Core / Common -> `cilium/proxy`
* FQDN (and integration) -> `cilium/fqdn`
* Envoy (and integration) -> `cilium/envoy`

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/codeowners-proxy branch from 0425e5b to 60b08a6 Compare December 5, 2023 11:43
@mhofstetter mhofstetter changed the title codeowners: use new teams cilium/envoy & cilium/proxy codeowners: use new teams cilium/envoy & cilium/fqdn Dec 5, 2023
@aanm aanm merged commit 8691035 into cilium:main Dec 5, 2023
42 of 43 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/codeowners-proxy branch December 5, 2023 14:20
@tklauser tklauser mentioned this pull request Dec 6, 2023
Merged
@tklauser
Copy link
Member

tklauser commented Dec 6, 2023

Looks like Documentation/codeowners.rst should have been regenerated as part of this change to contain the new teams (make -C Documentation update-codeowners), see #29669 (comment). Travis CI was even failing on this PR signalling this ;)

@tklauser
Copy link
Member

tklauser commented Dec 7, 2023

Looks like Documentation/codeowners.rst should have been regenerated as part of this change to contain the new teams (make -C Documentation update-codeowners), see #29669 (comment). Travis CI was even failing on this PR signalling this ;)

Opened #29685 to also check code owners in docs during CODEOWNERS CI, so this should fail earlier and be more visible even if docs build/check are skipped on a PR.

@joestringer joestringer mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@squeed squeed squeed approved these changes

@aanm aanm aanm approved these changes

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mhofstetter @tklauser @squeed @aanm @sayboras