Clean up deprecated and unused IPCache APIs after FQDN transition to asynchronous APIs #29657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
kind/cleanup
|
Nice! |
tklauser
force-pushed
the
pr/tklauser/ipcache-fqdn-async-review-follow-up
branch
2 times, most recently
from
8e5ab89
to
eed791c
Compare
|
/test |
ti-mo
approved these changes
Dec 6, 2023
tklauser
added a commit
that referenced
this pull request
Dec 6, 2023
Ref. #29657 (review) Signed-off-by: Tobias Klauser <tobias@cilium.io>
Opened #29669 to assign to @cilium/sig-agent. |
joestringer
reviewed
Dec 6, 2023
danehans
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Other than https://github.com/cilium/cilium/pull/29657/files#r1417759146, /LGTM.
Commit 6af2b78 ("ipcache/md: Make IPCache.metadata.remove() generic") changed the method name. Signed-off-by: Tobias Klauser <tobias@cilium.io>
This method is deprecated. Since commit 507259f ("fqdn: move to asynchronous ipcache APIs") its only user is in pkg/ipcache. Unexport it so no new code will accidentally use it. Signed-off-by: Tobias Klauser <tobias@cilium.io>
The AllocateCIDRsForIPs and ReleaseCIDRIdentitiesByID methods are deprecated API and not used anymore since commit 507259f ("fqdn: move to asynchronous ipcache APIs"). Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/ipcache-fqdn-async-review-follow-up
branch
from
eed791c
to
74c8f16
Compare
|
/test |
tklauser
added a commit
that referenced
this pull request
Dec 6, 2023
Ref. #29657 (review) Signed-off-by: Tobias Klauser <tobias@cilium.io>
|
Looks like Chris already covered review for ci-structure. |
joestringer
deleted the
pr/tklauser/ipcache-fqdn-async-review-follow-up
branch
aanm
pushed a commit
that referenced
this pull request
Dec 7, 2023
Ref. #29657 (review) Signed-off-by: Tobias Klauser <tobias@cilium.io>
learnitall
pushed a commit
to learnitall/cilium
that referenced
this pull request
Dec 9, 2023
Ref. cilium#29657 (review) Signed-off-by: Tobias Klauser <tobias@cilium.io>
pjablonski123
pushed a commit
to pjablonski123/cilium
that referenced
this pull request
Dec 15, 2023
Ref. cilium#29657 (review) Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up some deprecated/unused ipcache API following #29036 (fixing issue #28930). I've noticed these could be dropped while re-reviewing that PR after merge.
See commits for details.