gha: add step to ensure presence/absence of the AWS iptables chains #29670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
area/CI
|
/ci-eks |
|
/ci-awscni |
|
/ci-eks |
|
/ci-awscni |
giorio94
force-pushed
the
pr/giorio94/main/aws-iptables-cleanup-test
branch
from
5ef76a4
to
c97d552
Compare
|
/ci-awscni |
|
/ci-eks |
giorio94
force-pushed
the
pr/giorio94/main/aws-iptables-cleanup-test
branch
from
c97d552
to
e1c0767
Compare
|
/ci-awscni |
|
/ci-eks |
giorio94
force-pushed
the
pr/giorio94/main/aws-iptables-cleanup-test
branch
from
e1c0767
to
a9229e1
Compare
|
Marking as ready to review to start gathering feedback. It depends on #29448 to pass. |
giorio94
added
dont-merge/blocked
brlbil
approved these changes
Dec 6, 2023
|
Seems like a reasonable approach 👍 |
nebril
approved these changes
Dec 8, 2023
Recently, a regression of the poststart-eni.sh script got unnoticed, as we are not explicitly testing it as part of the E2E pipelines. Let's add a step to the Conformance EKS and Conformance AWS-CNI workflows to assert that, in the former case, the stale AWS iptables chains are removed, and in the latter they are not modified. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/main/aws-iptables-cleanup-test
branch
from
a9229e1
to
6a5845c
Compare
|
#29448 got merged. Rebased onto main, and removing the blocked label |
|
/test |
giorio94
removed
the
dont-merge/blocked
giorio94
added
the
ready-to-merge
giorio94
added
backport-pending/1.14
github-actions
bot
added
backport-done/1.14
gentoo-root
moved this from Needs backport from main
to Backport done to v1.14
in 1.14.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, a regression of the poststart-eni.sh script got unnoticed, as we are not explicitly testing it as part of the E2E pipelines.
Let's add a step to the Conformance EKS and Conformance AWS-CNI workflows to assert that, in the former case, the stale AWS iptables chains are removed, and in the latter they are not modified.
Link to failing run (without the fix):
Link to successful runs (with the fix):