Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.12: vendor: update logrus v1.9.0 => v1.9.3 #29673

Merged
merged 1 commit into from
Dec 8, 2023
Merged

v1.12: vendor: update logrus v1.9.0 => v1.9.3 #29673

merged 1 commit into from
Dec 8, 2023

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Dec 6, 2023

Release v1.9.3 address a potential DoS vulnerability.

Update the logrus dependency to address a security issue.

@rolinh rolinh added kind/backports This PR provides functionality previously merged into master. release-note/misc This PR makes changes that have no direct user impact. release-blocker/1.12 This issue will prevent the release of the next version of Cilium. backport/1.12 This PR represents a backport for Cilium 1.12.x of a PR that was merged to main. labels Dec 6, 2023
@rolinh rolinh requested a review from a team as a code owner December 6, 2023 15:16
@rolinh
Copy link
Member Author

rolinh commented Dec 6, 2023 •
edited by maintainer-s-little-helper bot

/test-backport-1.12

Job 'Cilium-PR-K8s-1.22-kernel-4.9' failed:

Click to show.

Test Name

K8sUpdates Tests upgrade and downgrade from a Cilium stable image to master

Failure Output

FAIL: Timed out after 30.001s.

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.22-kernel-4.9/231/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.22-kernel-4.9 so I can create one.

Then please upload the Jenkins artifacts to that issue.

Job 'Cilium-PR-K8s-1.22-kernel-4.9' failed:

Click to show.

Test Name

K8sServicesTest Checks graceful termination of service endpoints Checks client terminates gracefully on service endpoint deletion

Failure Output

FAIL: Timed out after 60.001s.

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.22-kernel-4.9/232/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.22-kernel-4.9 so I can create one.

Then please upload the Jenkins artifacts to that issue.

@rolinh
Copy link
Member Author

rolinh commented Dec 7, 2023

Looks like a flake, I'll re-trigger the test

	 Error: INSTALLATION FAILED: cannot re-use a name that is still in use

@rolinh
Copy link
Member Author

rolinh commented Dec 7, 2023

/test-1.22-4.9

@rolinh rolinh force-pushed the pr/rolinh/v1.12-vendor-update branch from cd6c686 to 528c12a Compare December 7, 2023 12:02
@rolinh
vendor: update logrus v1.9.0 => v1.9.3
8a27f03 
Release v1.9.3 address a potential DoS vulnerability.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh force-pushed the pr/rolinh/v1.12-vendor-update branch from 528c12a to 8a27f03 Compare December 7, 2023 15:30
@rolinh
Copy link
Member Author

rolinh commented Dec 7, 2023 •
edited by maintainer-s-little-helper bot

/test-backport-1.12

Job 'Cilium-PR-K8s-1.24-kernel-net-next' hit: #29668 (94.16% similarity)

@maintainer-s-little-helper maintainer-s-little-helper bot mentioned this pull request Dec 7, 2023
Closed
@aanm
Copy link
Member

aanm commented Dec 8, 2023

/test-1.24-net-next

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 8, 2023
@aanm aanm merged commit 641c175 into v1.12 Dec 8, 2023
109 checks passed
@aanm aanm deleted the pr/rolinh/v1.12-vendor-update branch December 8, 2023 14:22
@nebril nebril mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-mo ti-mo ti-mo approved these changes

Assignees
No one assigned
Labels
backport/1.12 This PR represents a backport for Cilium 1.12.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-blocker/1.12 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rolinh @aanm @ti-mo