[v1.13] Make logging.InitializeDefaultLogger private #29700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit: b175548 ] The function InitializeDefaultLogger creates a new logger with the default settings and returns it. This commit removes a call to this function that doesn't save the return value, essentially calling it for no reason. Signed-off-by: Ryan Drew <ryan.drew@isovalent.com> Signed-off-by: Anton Ippolitov <anton.ippolitov@datadoghq.com>
maintainer-s-little-helper
bot
added
backport/1.13
github-actions
bot
added
the
kind/community-contribution
|
/test-backport-1.13 |
8 tasks
[ upstream commit 00ab252 ] [ Backporter's notes: ignoring changes from cilium#26327 and cilium#23971 ] The DefaultLogger variable in the logging module serves as a parent logger which all other loggers can be derived from. It is initialized using the InitializeDefaultLogger function and then adjusted on startup based on user configuration. Users should not call InitializeDefaultLogger to create a parent logger for their logger, since the logger returned by InitializeDefaultLogger will always use the hardcoded defaults. For example, the logger returned will always be of level INFO, even if a user has enabled debug logging. To make this clear, this commit renames InitializeDefaultLogger to initializeDefaultLogger to signal that it should not be used outside of the logging module. Fixes: cilium#29215 Signed-off-by: Ryan Drew <ryan.drew@isovalent.com> Signed-off-by: Anton Ippolitov <anton.ippolitov@datadoghq.com>
antonipp
force-pushed
the
ai/backport-29495-1-13
branch
from
ffb16ef
to
d05348f
Compare
|
I missed a small issue in the tests, going to re-run the suite again :( |
|
/test-backport-1.13 |
ti-mo
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
I've requested a review from @learnitall to double check. I'll unblock the @cilium/tophat review.
learnitall
approved these changes
Dec 7, 2023
|
/test-backport-1.13 |
|
The failing "Cilium IPsec upgrade" tests seem to be completely unrelated, looks like it's a known issue described here: #29351 (comment) |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.13 backport for #29495
As mentioned in #29495 (comment), the original PR contained code which relied on changes made in #26327 and #23971. I tried to workaround this as much as possible to make the backport as minimal and self-contained as possible:
atomic.StorePointer+unsafe.Pointerinpkg/endpoint/log.goand didn't touch other files changed in that PRpkg/endpoint/log.goand didn't touch other files changed in that PROnce this PR is merged, a GitHub action will update the labels of these PRs: