identity: deflake test TestGetIdentity #29720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the test `TestGetIdentity` fails with the following error.
```
--- FAIL: TestGetIdentity (0.85s)
--- FAIL: TestGetIdentity/Multiple_identities (0.26s)
identity_test.go:226: Identity not found in the store
```
The reason is that the watch of the backend (started in its own
goroutine) might not be ready when the test starts to create test
identities.
Therefore, this commit introduces that the test waits with its
continuation until the watch is ready.
Fixes: cilium#23856
Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
added
kind/bug/CI
|
/test |
tommyp1ckles
approved these changes
Dec 13, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
joestringer
added
the
needs-backport/1.15
pippolo84
added
backport-pending/1.15
aanm
added
backport-done/1.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the test
TestGetIdentityfails with the following error.The reason is that the watch of the backend (started in its own goroutine) might not be ready when the test starts to create test identities.
Therefore, this PR introduces that the test waits with its continuation until the listener is ready.
Fixes: #23856