Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cilium: Do not warn on socket tracing if EnableSocketLBTracing was not set #29730

Merged
merged 1 commit into from
Dec 8, 2023
Merged

cilium: Do not warn on socket tracing if EnableSocketLBTracing was not set #29730

merged 1 commit into from
Dec 8, 2023

Conversation

borkmann
Copy link
Member

@borkmann borkmann commented Dec 8, 2023

(see commit msg)

@borkmann
cilium: Do not warn on socket tracing if EnableSocketLBTracing was no…
a4dcf61 
…t set

Do not spam the agent log with the feature probe if the socket tracing was
not enabled in the first place. Also the !option.Config.EnableSocketLB
branch is not needed since option.Config.EnableSocketLB was checked to be
true further above.

Reported-by: Paul Chaignon <paul.chaignon@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Dec 8, 2023
@borkmann borkmann requested a review from rgo3 December 8, 2023 10:41
@borkmann borkmann requested a review from a team as a code owner December 8, 2023 10:41
@borkmann
Copy link
Member Author

borkmann commented Dec 8, 2023

/test

@rgo3 rgo3 mentioned this pull request Dec 8, 2023
Closed
@rgo3 rgo3 linked an issue Dec 8, 2023 that may be closed by this pull request
Unavoidable warning Disabling socket-LB tracing as it requires kernel 5.7 or newer #29734
Closed
pchaigno
pchaigno approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borkmann Given the feature is enabled by default, it will keep popping up in all CI jobs that don't run Linux v5.7+. Are you planning to send a PR for that?

@pchaigno pchaigno added this pull request to the merge queue Dec 8, 2023
Merged via the queue into main with commit 9330f0e Dec 8, 2023
207 checks passed
@pchaigno pchaigno deleted the pr/sk-trace-warn branch December 8, 2023 11:55
@borkmann
Copy link
Member Author

borkmann commented Dec 8, 2023

@borkmann Given the feature is enabled by default, it will keep popping up in all CI jobs that don't run Linux v5.7+. Are you planning to send a PR for that?

Is the suggestion to just remove the warning altogether? Perhaps this should be moved to KPR status for cilium status --verbose to provide some visibility whether sock tracing is there or not. Cc @aditighag

@joestringer joestringer mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@rgo3 rgo3 rgo3 approved these changes

@ldelossa ldelossa Awaiting requested review from ldelossa ldelossa is a code owner automatically assigned from cilium/sig-datapath

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unavoidable warning Disabling socket-LB tracing as it requires kernel 5.7 or newer
3 participants
@borkmann @pchaigno @rgo3