Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.13] ci: In conn-disrupt-test action, disable node-to-node-encryption check #29741

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented Dec 8, 2023

The node-to-node-encryption test is known to fail often on branches v1.13 and v1.14 with jobs running on kernels 5.4 and 5.10, and so far we haven't been able to figure out why. The test brings little value anyway, so we disable it on the branches.

Link: #29351

@qmonnet qmonnet added area/CI Continuous Integration testing issue or flake kind/backports This PR provides functionality previously merged into master. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. feature/ipsec Relates to Cilium's IPsec feature labels Dec 8, 2023
@qmonnet qmonnet requested a review from brb December 8, 2023 14:07
@qmonnet qmonnet requested a review from a team as a code owner December 8, 2023 14:07
@maintainer-s-little-helper maintainer-s-little-helper bot added the backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. label Dec 8, 2023
@qmonnet
Copy link
Member Author

qmonnet commented Dec 8, 2023

/test-backport-1.13

The node-to-node-encryption test is known to fail often on branches
v1.13 and v1.14 with jobs running on kernels 5.4 and 5.10, and so far we
haven't been able to figure out why. The test brings little value
anyway, so we disable it on the branches.

Link: #29351
Signed-off-by: Quentin Monnet <quentin@isovalent.com>
@qmonnet qmonnet force-pushed the pr/qmonnet/ipsec/disable-n2n-enc-test branch from e968473 to 7d9f9c5 Compare December 8, 2023 15:17
@qmonnet
Copy link
Member Author

qmonnet commented Dec 8, 2023

/test-backport-1.13

Job 'Cilium-PR-K8s-1.21-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks E/W loadbalancing (ClusterIP, NodePort from inside cluster, etc) with L7 policy Tests NodePort with L7 Policy

Failure Output

FAIL: Request from k8s1 to service http://[fd04::11]:32230 failed

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.19/298/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.21-kernel-4.19 so I can create one.

Then please upload the Jenkins artifacts to that issue.

@qmonnet qmonnet mentioned this pull request Dec 8, 2023
@joestringer joestringer removed the backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. label Dec 8, 2023
@qmonnet
Copy link
Member Author

qmonnet commented Dec 11, 2023

Oh sorry I didn't realise I set the wrong label, thanks Joe!

PR tested here, with success:

image

@qmonnet qmonnet mentioned this pull request Dec 11, 2023
3 tasks
@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 11, 2023
@aanm aanm added the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Dec 11, 2023
@aanm aanm assigned aanm and nebril and unassigned aanm Dec 11, 2023
@aanm aanm removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 11, 2023
@nebril nebril added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs labels Dec 14, 2023
@nebril nebril merged commit 8646989 into v1.13 Dec 14, 2023
125 of 135 checks passed
@nebril nebril deleted the pr/qmonnet/ipsec/disable-n2n-enc-test branch December 14, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. feature/ipsec Relates to Cilium's IPsec feature kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
No open projects
Status: Released
Development

Successfully merging this pull request may close these issues.

None yet

5 participants