[v1.13] Let renovatebot update Go toolchain version in a single PR #29743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit d8dba60 ] We only support building with the Go version specified in GO_VERSION (currently Go 1.20.1), thus the second condition (version >= go 1.13) is always true. Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit f0039ae ] [ backporter's note: skipped files not existent on v1.13. This makes sure Go version in CI gets update by renovate as well to match the version used in the runtime and builder images, i.e. the version used to build the release binaries. ] This allows renovate bot to update Go version in GitHub actions. Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit 393eb88 ] This allows renovate bot to update the Go version used for Travis CI. Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit f5777c6 ] Instead of manually downloading and installing the Go toolchain tarball, let's just copy it from the golang image. This will allow renovate bot to automatically update the image and thus the Go version. Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit f731d6c ] This allows renovate bot to update the Go version in test scripts used within the CI VMs. Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit e718a35 ] Instead of having a make target update the minimum required Go version, let dev-doctor extract it from the main module's go.mod file. Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit ca4f4f8 ] [ backporter's notes: skipped files not existent on v1.13. Trivial merge conflicts in CODEOWNERS resolved by keeping the current version. ] All remaining users of the GO_VERSION file were either converted to be updated by renovate or to use the go.mod file (in case only major and minor version are required) in previous commits. Delete the now unneeded GO_VERSION file. Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit 66377a3 ] These build tags lead to a rather unhelpful error message when compiling an outdated Go versions, e.g. package github.com/cilium/cilium/daemon: build constraints exclude all Go files in ... Nothing in the error messages indicates that this is due to an outdated Go toolchain version and this has been a source of confusion several times for several developers. It's also brittle in a way that if a developer adds a new tool with a main func and forgets adding the //go:build line it will not be enforced by tooling. The update-go-version make target will only cover existing //go:build go1.X lines. We have other checks in place to guarantee that Cilium is built using the correct Go version (namely the go directive in go.mod, the check-go-version make target, the dev-doctor tool and various CI checks), so drop these build tags. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
kind/backports
|
/test-backport-1.13 |
aanm
approved these changes
Dec 8, 2023
nebril
approved these changes
Dec 8, 2023
|
/test-1.19-4.19 |
|
/test-1.20-4.19 |
|
/test-1.24-4.19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author backport of #24895. This allows renovate to consistently update the Go version in v1.13, i.e. so the Go version used to build the release images is the same that is used in CI.