Revert "cilium: Ensure xfrm state is initialized for route IP before … #29801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…publish" This reverts commit c9ea7a5. This works around a condition where restarting the agent uses a new IP for Cilium Internal IP. But, it turns out this is because of an incorrect set helm chart option in our reproducer. When configured correctly we require CiliumInternalIP to reused so this patch is not necessary. In fact it complicates the code so lets drop it. The helm option is cleanState. It must be set to false cleanState=false Note that cleanState="false" is a string type and will default to true because of bool typing. Creating a subtle and broke config. Signed-off-by: John Fastabend <john.fastabend@gmail.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
jrfastab
force-pushed
the
pr/jrfastab/revert-ipsec-init
branch
from
841c594
to
30399d7
Compare
pchaigno
approved these changes
Dec 12, 2023
|
/test |
pchaigno
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
pchaigno
added
area/encryption
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
joestringer
approved these changes
Dec 13, 2023
jrfastab
added
the
backport/author
1 task
jrfastab
added
backport-pending/1.14
1 task
jrfastab
added
backport-pending/1.13
This was referenced Dec 13, 2023
This was referenced Dec 13, 2023
jrfastab
added
the
backport-pending/1.15
github-actions
bot
added
backport-done/1.12
michi-covalent
removed
the
backport-pending/1.15
github-actions
bot
added
backport-done/1.13
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c9ea7a5.
This works around a condition where restarting the agent uses a new
IP for Cilium Internal IP. But, it turns out this is because of an
incorrect set helm chart option in our reproducer. When configured
correctly we require CiliumInternalIP to reused so this patch is not
necessary. In fact it complicates the code so lets drop it.
The helm option is cleanState. It must be set to false
cleanState=false
Note that cleanState="false" is a string type and will default to
true because of bool typing. Creating a subtle and broke config.
Signed-off-by: John Fastabend john.fastabend@gmail.com