Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

endpoint: Use resolved named port also in the proxy stats #29813

Merged
merged 1 commit into from
Dec 19, 2023
Merged

endpoint: Use resolved named port also in the proxy stats #29813

merged 1 commit into from
Dec 19, 2023

Conversation

jrajahalme
Copy link
Member

Commit 10f04fd (endpoint: Resolve named ports for redirects) fixed redirect creation for L7 policies using a named port, but failed to use the resolved destination port also in proxy stats. This commit does that.

Fixes: #29023

@jrajahalme
endpoint: Use resolved named port also in the proxy stats
0d6a41b 
Commit 10f04fd (endpoint: Resolve named
ports for redirects) fixed redirect creation for L7 policies using a
named port, but failed to use the resolved destination port also in proxy
stats. This commit does that.

Fixes: cilium#29023
Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme added kind/bug This is a bug in the Cilium logic. area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. release-note/misc This PR makes changes that have no direct user impact. release-blocker/1.15 This issue will prevent the release of the next version of Cilium. labels Dec 12, 2023
@jrajahalme jrajahalme requested a review from a team as a code owner December 12, 2023 11:57
@jrajahalme
Copy link
Member Author

/test

@jrajahalme
Copy link
Member Author

Carved this bug fix out from #28555 that missed the feature freeze deadline.

@jrajahalme jrajahalme mentioned this pull request Dec 12, 2023
Merged
@jrajahalme jrajahalme added the needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch label Dec 13, 2023
@joestringer joestringer added this to Needs backport from main in v1.15.0-rc.1 Dec 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 19, 2023
@julianwiedmann julianwiedmann added this pull request to the merge queue Dec 19, 2023
Merged via the queue into cilium:main with commit a573bb4 Dec 19, 2023
63 checks passed
@pippolo84 pippolo84 mentioned this pull request Jan 2, 2024
Merged
17 tasks
@pippolo84 pippolo84 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Jan 2, 2024
@aanm aanm added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 16, 2024
@aanm aanm mentioned this pull request Jan 16, 2024
Merged
@aanm aanm moved this from Needs backport from main to Backport done to v1.15 in v1.15.0-rc.1 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanjsweet nathanjsweet nathanjsweet approved these changes

Assignees
No one assigned
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-blocker/1.15 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
v1.15.0-rc.1
Backport done to v1.15
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jrajahalme @nathanjsweet @pippolo84 @aanm @julianwiedmann