Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loader: refactor/cleanup replaceNetworkDatapath #29825

Merged
merged 1 commit into from Dec 18, 2023

Conversation

rgo3
Copy link
Contributor

@rgo3 rgo3 commented Dec 12, 2023

replaceNetworkDatapath() is only called from one place and adds an additional loop over the encryption devices. This commit removes the function and calls replaceDatapath() from reinitializeIPSec() directly.

There are no functional changes.

@rgo3 rgo3 added sig/loader Impacts the loading of BPF programs into the kernel. release-note/misc This PR makes changes that have no direct user impact. labels Dec 12, 2023
@rgo3
Copy link
Contributor Author

rgo3 commented Dec 12, 2023

/test

@rgo3 rgo3 marked this pull request as ready for review December 12, 2023 19:32
@rgo3 rgo3 requested a review from a team as a code owner December 12, 2023 19:33
@aanm aanm enabled auto-merge December 13, 2023 23:20
@aanm aanm disabled auto-merge December 13, 2023 23:21
@ti-mo ti-mo requested review from ti-mo and removed request for dylandreimerink December 14, 2023 14:52
Copy link
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy bien, muchas gracias!

pkg/datapath/loader/base.go Outdated Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Dec 14, 2023
replaceNetworkDatapath() is only called from one place and adds an
additional loop over the encryption devices. This commit removes the
function and calls replaceDatapath() from reinitializeIPSec() directly.

There are no functional changes.

Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
@rgo3
Copy link
Contributor Author

rgo3 commented Dec 14, 2023

/test

@ti-mo ti-mo enabled auto-merge December 18, 2023 13:03
@julianwiedmann julianwiedmann merged commit 1409a37 into cilium:main Dec 18, 2023
61 of 62 checks passed
@ti-mo ti-mo deleted the cleanup-ipsec-attachment branch January 11, 2024 13:29
@ti-mo ti-mo added the backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. label Mar 28, 2024
@rgo3 rgo3 added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/loader Impacts the loading of BPF programs into the kernel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants