Conformance AKS: wait for cilium-test namespace deletion during uninstallation #29893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the wait flag to cilium uninstall in Conformance AKS, so that we ensure that the cilium-test namespace gets effectively deleted before uninstalling and reinstalling Cilium. This ensures that the connectivity tests can then be started correctly (i.e., that the namespace can be created) and prevents Cilium errors such as: msg="Cannot create CEP" error="... forbidden: unable to create new content in namespace cilium-test because it is being terminated" Finally, it brings also consistency with what we already do in the other workflows. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
area/CI
|
/ci-aks |
|
@brlbil Gentle ping :-) |
brlbil
approved these changes
Jan 8, 2024
|
Reviews are in, and changes are trivial and affect a single GHA workflow, which is green. Marking as ready to merge without running the full CI suite. |
giorio94
added
the
ready-to-merge
|
/test |
dylandreimerink
deleted the
pr/giorio94/main/conformance-aks-uninstall-wait
branch
jibi
added
backport-pending/1.14
jibi
added
backport-pending/1.15
github-actions
bot
added
backport-done/1.14
giorio94
added
backport-done/1.15
aanm
moved this from Needs backport from main
to Backport done to v1.15
in v1.15.0-rc.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the wait flag to cilium uninstall in Conformance AKS, so that we ensure that the cilium-test namespace gets effectively deleted before uninstalling and reinstalling Cilium. This ensures that the connectivity tests can then be started correctly (i.e., that the namespace can be created) and prevents Cilium errors such as:
Finally, it brings also consistency with what we already do in the other workflows.
For cilium/cilium-cli#2184