Envoy: add NACK processing #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Since the last update on the cilium agent envoy API code, the behavior had changed to keep sending the same resource version over and over if Envoy rejects the resource. Fix this by properly differentiating between ACKs and NACKs. A NACK now causes a watcher to wait until the resource is updated before sending it over again. This was found due to the new policy resources failing protobuf content validation that Envoy checks for. We should test for the NACK behavior as well to prevent future regressions. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
added
kind/bug
|
test-me-please |
rlenglet
approved these changes
Mar 1, 2018
tgraf
added
the
release-note/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the last update on the cilium agent envoy API code, the behavior
had changed to keep sending the same resource version over and over if
Envoy rejects the resource. Fix this by properly differentiating
between ACKs and NACKs. A NACK now causes a watcher to wait until the
resource is updated before sending it over again.
This was found due to the new policy resources failing protobuf
content validation that Envoy checks for.
Signed-off-by: Jarno Rajahalme jarno@covalent.io