Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable additional tests as part of the conformance-clustermesh workflow #29926

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Enable additional tests as part of the conformance-clustermesh workflow #29926

merged 5 commits into from
Jan 16, 2024

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Dec 15, 2023 •
edited
Loading

Extend the conformance-clustermesh workflow coverage:

  • Always assign the first and last ClusterID to the two clusters;
  • Enable north/south loadbalancing tests from external node;
  • Enable ingress-related tests.
Improve Conformance Cluster Mesh workflow coverage

Requires cilium/cilium-cli#2191

@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/ci This PR makes changes to the CI. labels Dec 15, 2023
@giorio94 giorio94 force-pushed the pr/giorio94/main/extend-conformance-clustermesh-tests branch from 77d744e to 35b6f17 Compare December 15, 2023 17:52
@giorio94
Copy link
Member Author

/ci-clustermesh

@giorio94 giorio94 added the backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. label Dec 18, 2023
@giorio94 giorio94 force-pushed the pr/giorio94/main/extend-conformance-clustermesh-tests branch from d98f16c to e5010d2 Compare December 18, 2023 08:20
@giorio94
Copy link
Member Author

/ci-clustermesh

@giorio94 giorio94 force-pushed the pr/giorio94/main/extend-conformance-clustermesh-tests branch from e5010d2 to 7d93f9c Compare December 18, 2023 08:42
@giorio94
Copy link
Member Author

/ci-clustermesh

@giorio94 giorio94 force-pushed the pr/giorio94/main/extend-conformance-clustermesh-tests branch from 7d93f9c to ecb404b Compare December 18, 2023 11:02
@giorio94
Copy link
Member Author

/ci-clustermesh

@giorio94 giorio94 force-pushed the pr/giorio94/main/extend-conformance-clustermesh-tests branch from ecb404b to 1f4a3cb Compare December 18, 2023 11:28
@giorio94
Copy link
Member Author

/ci-clustermesh

@giorio94
Copy link
Member Author

/ci-e2e

@giorio94 giorio94 mentioned this pull request Dec 18, 2023
Merged
@giorio94 giorio94 added needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch and removed backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. labels Dec 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in v1.15.0-rc.1 Dec 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.6 Dec 20, 2023
@giorio94 giorio94 added the backport/author The backport will be carried out by the author of the PR. label Dec 20, 2023
@giorio94 giorio94 force-pushed the pr/giorio94/main/extend-conformance-clustermesh-tests branch from 1f4a3cb to 29c0b97 Compare December 20, 2023 14:15
@giorio94
Copy link
Member Author

/ci-clustermesh

@giorio94 giorio94 force-pushed the pr/giorio94/main/extend-conformance-clustermesh-tests branch from 29c0b97 to 6f32a31 Compare January 9, 2024 16:25
@giorio94
Copy link
Member Author

giorio94 commented Jan 9, 2024

/ci-clustermesh

@giorio94
Copy link
Member Author

giorio94 commented Jan 9, 2024

Cluster Mesh workflows are green. Opening for review, to start gathering feedback. At the same time, marking as blocked until a new version of the Cilium CLI gets released, as the last commit needs to be dropped.

@giorio94 giorio94 added the dont-merge/blocked Another PR must be merged before this one. label Jan 9, 2024
@giorio94 giorio94 marked this pull request as ready for review January 9, 2024 16:48
@giorio94 giorio94 requested a review from a team as a code owner January 9, 2024 16:48
viktor-kurchenko
viktor-kurchenko approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 16, 2024
@viktor-kurchenko
Copy link
Contributor

@viktor-kurchenko Gentle ping

Sorry, missed it (

@giorio94
Copy link
Member Author

@viktor-kurchenko Gentle ping

Sorry, missed it (

Np, thanks!

@tklauser tklauser added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit cbae172 Jan 16, 2024
205 checks passed
@tklauser tklauser deleted the pr/giorio94/main/extend-conformance-clustermesh-tests branch January 16, 2024 10:37
@gentoo-root gentoo-root added this to Needs backport from main in 1.14.7 Jan 17, 2024
@gentoo-root gentoo-root removed this from Needs backport from main in 1.14.6 Jan 17, 2024
@giorio94 giorio94 removed the backport/author The backport will be carried out by the author of the PR. label Jan 22, 2024
@giorio94 giorio94 mentioned this pull request Jan 22, 2024
Merged
12 tasks
@giorio94 giorio94 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Jan 22, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in v1.15.0-rc.1 Jan 22, 2024
@giorio94 giorio94 mentioned this pull request Jan 22, 2024
Merged
11 tasks
@giorio94 giorio94 added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jan 22, 2024
@giorio94
Copy link
Member Author

I'm not backporting these CI changes to v1.12 and v1.13, as those branches still use the v0.14 series of the Cilium CLI.

@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jan 25, 2024
@giorio94 giorio94 added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.15 to Backport done to v1.15 in v1.15.0-rc.1 Jan 29, 2024
@michi-covalent michi-covalent moved this from Needs backport from main to Backport done to v1.14 in 1.14.7 Feb 13, 2024
@michi-covalent michi-covalent mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

@aditighag aditighag aditighag approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.14.7
Backport done to v1.14
cilium v1.14.7
Status: Released
v1.15.0-rc.1
Backport done to v1.15
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@giorio94 @viktor-kurchenko @YutaroHayakawa @aditighag @tklauser