Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport-1.15] policy: expand "world" entity selector to select all address families #29961

Merged
merged 1 commit into from
Dec 18, 2023
Merged

[backport-1.15] policy: expand "world" entity selector to select all address families #29961

merged 1 commit into from
Dec 18, 2023

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Dec 18, 2023 •
edited
Loading

Fixes: #29666

Once this PR is merged, a GitHub action will update the labels of these PRs:

29958

@squeed
policy: expand "world" entity selector to select all address families
0042883 
[ upstream commit 1288473 ]

Previously, we had a single label, `reserved:world`, applied to all CIDR
(non-cluster) identities. With cilium#22625, this is no longer the case; CIDR
identities get either `reserved:world-ipv4` or `reserved:world-ipv6`
labels **in dual stack clusters**.

This PR updates the `toEntities: world` selector to select *all* world
entities, as it worked previously. It does so by expanding the set of
selectors underlying the `world` entity. No other magic in the
SelectorCache or policy engine is required.

Fixes: cilium#29666
Fixes: a94fa56

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
@squeed squeed requested a review from a team as a code owner December 18, 2023 14:34
@squeed squeed added kind/backports This PR provides functionality previously merged into master. backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. labels Dec 18, 2023
@squeed squeed changed the title v1.15 backports 2023-12-18 [backport-1.13] policy: expand "world" entity selector to select all address families Dec 18, 2023
@squeed squeed added the release-blocker/1.15 This issue will prevent the release of the next version of Cilium. label Dec 18, 2023
@squeed
Copy link
Contributor Author

squeed commented Dec 18, 2023

/test-backport-1.15

@mhofstetter mhofstetter changed the title [backport-1.13] policy: expand "world" entity selector to select all address families [backport-1.15] policy: expand "world" entity selector to select all address families Dec 18, 2023
@squeed
Copy link
Contributor Author

squeed commented Dec 18, 2023

Green!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 18, 2023
@julianwiedmann julianwiedmann merged commit 9c6f05a into cilium:v1.15 Dec 18, 2023
61 checks passed
@aanm aanm mentioned this pull request Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianwiedmann julianwiedmann julianwiedmann approved these changes

Assignees
No one assigned
Labels
backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-blocker/1.15 This issue will prevent the release of the next version of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@squeed @julianwiedmann