daemon: Remove obsolete bpf-lb-dev-ip-addr-inherit option #29963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option was added for a niche use-case that no longer needs it and the agent did not anymore support it. Remove the remaining code related to it. Signed-off-by: Jussi Maki <jussi@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
To give some more background, this was added for a specific use-case for one user of Cilium and it was confirmed that use-case is gone now. We can fairly safely assume this option was never used by anyone else as it was never exposed via the helm values. |
joamaki
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
asauber
approved these changes
Dec 19, 2023
joamaki
added
the
needs-backport/1.15
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
gandro
added
backport-pending/1.15
gandro
added
backport-done/1.15
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport done to v1.15
in v1.15.0-rc.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was added for a niche use-case that no longer needs it and the agent did not anymore support it. Remove the remaining code related to it.