-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the clustermesh workflows to additionally cover the external kvstore case #29983
Merged
sayboras
merged 5 commits into
main
from
pr/giorio94/main/conformance-clustermesh-kvstore
Jan 16, 2024
Merged
Extend the clustermesh workflows to additionally cover the external kvstore case #29983
sayboras
merged 5 commits into
main
from
pr/giorio94/main/conformance-clustermesh-kvstore
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
area/CI
Continuous Integration testing issue or flake
area/clustermesh
Relates to multi-cluster routing functionality in Cilium.
release-note/ci
This PR makes changes to the CI.
labels
Dec 19, 2023
giorio94
force-pushed
the
pr/giorio94/main/conformance-clustermesh-kvstore
branch
2 times, most recently
from
December 19, 2023 11:32
3b7bd47
to
7d34b47
Compare
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
The author needs to add signoff to their commits before merge.
label
Dec 19, 2023
giorio94
force-pushed
the
pr/giorio94/main/conformance-clustermesh-kvstore
branch
from
December 19, 2023 13:40
6b02a9d
to
0be248a
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
The author needs to add signoff to their commits before merge.
label
Dec 19, 2023
giorio94
force-pushed
the
pr/giorio94/main/conformance-clustermesh-kvstore
branch
from
December 19, 2023 13:48
0be248a
to
eb29605
Compare
giorio94
force-pushed
the
pr/giorio94/main/conformance-clustermesh-kvstore
branch
12 times, most recently
from
December 20, 2023 09:09
b42919f
to
1ba46ae
Compare
giorio94
added
backport/author
The backport will be carried out by the author of the PR.
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
labels
Dec 20, 2023
giorio94
force-pushed
the
pr/giorio94/main/conformance-clustermesh-kvstore
branch
3 times, most recently
from
December 20, 2023 12:03
4606ae7
to
b061f6b
Compare
Make sure that the max connected clusters option works as expected in all configurations: clustermesh, kvstoremesh and external kvstore. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Let's extend the clustermesh upgrade/downgrade workflow with a new matrix entry to also cover the external kvstores configuration. We leverage the newly introduced kvstore action to setup the etcd containers and retrieve the appropriate parameters. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/main/conformance-clustermesh-kvstore
branch
from
January 15, 2024 15:49
66a7401
to
4c50f0b
Compare
Rebased onto main to drop the temporary commit, as the new version of the Cilium CLI including the necessary changes got released and bumped in all workflows. |
/test |
giorio94
removed
the
dont-merge/blocked
Another PR must be merged before this one.
label
Jan 15, 2024
This was referenced Jan 15, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Jan 15, 2024
giorio94
removed
the
backport/author
The backport will be carried out by the author of the PR.
label
Jan 22, 2024
giorio94
added
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
and removed
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
labels
Jan 22, 2024
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in v1.15.0-rc.1
Jan 22, 2024
giorio94
added
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
and removed
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
labels
Jan 22, 2024
github-actions
bot
added
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
and removed
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
labels
Jan 25, 2024
giorio94
added
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
and removed
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
labels
Jan 29, 2024
maintainer-s-little-helper
bot
moved this from Backport pending to v1.15
to Backport done to v1.15
in v1.15.0-rc.1
Jan 29, 2024
michi-covalent
moved this from Needs backport from main
to Backport done to v1.14
in 1.14.7
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
area/clustermesh
Relates to multi-cluster routing functionality in Cilium.
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's extend the conformance clustermesh and clustermesh upgrade/downgrade workflows to additionally cover the external kvstores configuration, in addition to plain clustermesh and kvstoremesh, to prevent possible regressions associated with that setup.
Please review commit by commit, and refer to the respective messages for additional details.
Depends on cilium/cilium-cli#2199