Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the clustermesh workflows to additionally cover the external kvstore case #29983

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Dec 19, 2023

Let's extend the conformance clustermesh and clustermesh upgrade/downgrade workflows to additionally cover the external kvstores configuration, in addition to plain clustermesh and kvstoremesh, to prevent possible regressions associated with that setup.

Please review commit by commit, and refer to the respective messages for additional details.

Depends on cilium/cilium-cli#2199

Extend the clustermesh workflows to additionally cover the external kvstore case

@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/ci This PR makes changes to the CI. labels Dec 19, 2023
@giorio94 giorio94 force-pushed the pr/giorio94/main/conformance-clustermesh-kvstore branch 2 times, most recently from 3b7bd47 to 7d34b47 Compare December 19, 2023 11:32
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Dec 19, 2023
@giorio94 giorio94 force-pushed the pr/giorio94/main/conformance-clustermesh-kvstore branch from 6b02a9d to 0be248a Compare December 19, 2023 13:40
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Dec 19, 2023
@giorio94 giorio94 force-pushed the pr/giorio94/main/conformance-clustermesh-kvstore branch from 0be248a to eb29605 Compare December 19, 2023 13:48
@cilium cilium deleted a comment from maintainer-s-little-helper bot Dec 19, 2023
@giorio94 giorio94 force-pushed the pr/giorio94/main/conformance-clustermesh-kvstore branch 12 times, most recently from b42919f to 1ba46ae Compare December 20, 2023 09:09
@giorio94 giorio94 added backport/author The backport will be carried out by the author of the PR. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Dec 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in v1.15.0-rc.1 Dec 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.6 Dec 20, 2023
@giorio94 giorio94 force-pushed the pr/giorio94/main/conformance-clustermesh-kvstore branch 3 times, most recently from 4606ae7 to b061f6b Compare December 20, 2023 12:03
Make sure that the max connected clusters option works as expected in
all configurations: clustermesh, kvstoremesh and external kvstore.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Let's extend the clustermesh upgrade/downgrade workflow with a new
matrix entry to also cover the external kvstores configuration. We
leverage the newly introduced kvstore action to setup the etcd
containers and retrieve the appropriate parameters.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the pr/giorio94/main/conformance-clustermesh-kvstore branch from 66a7401 to 4c50f0b Compare January 15, 2024 15:49
@giorio94
Copy link
Member Author

Rebased onto main to drop the temporary commit, as the new version of the Cilium CLI including the necessary changes got released and bumped in all workflows.

@giorio94
Copy link
Member Author

/test

@giorio94 giorio94 removed the dont-merge/blocked Another PR must be merged before this one. label Jan 15, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 15, 2024
@sayboras sayboras added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit 683a8e6 Jan 16, 2024
205 checks passed
@sayboras sayboras deleted the pr/giorio94/main/conformance-clustermesh-kvstore branch January 16, 2024 08:05
@gentoo-root gentoo-root added this to Needs backport from main in 1.14.7 Jan 17, 2024
@gentoo-root gentoo-root removed this from Needs backport from main in 1.14.6 Jan 17, 2024
@giorio94 giorio94 removed the backport/author The backport will be carried out by the author of the PR. label Jan 22, 2024
@giorio94 giorio94 mentioned this pull request Jan 22, 2024
12 tasks
@giorio94 giorio94 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Jan 22, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in v1.15.0-rc.1 Jan 22, 2024
@giorio94 giorio94 mentioned this pull request Jan 22, 2024
11 tasks
@giorio94 giorio94 added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jan 22, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jan 25, 2024
@giorio94 giorio94 added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.15 to Backport done to v1.15 in v1.15.0-rc.1 Jan 29, 2024
@michi-covalent michi-covalent moved this from Needs backport from main to Backport done to v1.14 in 1.14.7 Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.14.7
Backport done to v1.14
Status: Released
v1.15.0-rc.1
Backport done to v1.15
Development

Successfully merging this pull request may close these issues.

None yet

5 participants