labels: small optimization in NewFrom and various cleanups #30006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unused since commit 7eb7f22 ("EndpointSelector: replacing LabelArray with k8s LabelSelector"). Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
kind/cleanup
|
/test |
giorio94
approved these changes
Dec 20, 2023
Use the predefined const. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Allocate a label map of the correct known size. name old time/op new time/op delta NewFrom-8 638ns ± 8% 71ns ± 6% -88.87% (p=0.000 n=10+10) name old alloc/op new alloc/op delta NewFrom-8 624B ± 0% 0B -100.00% (p=0.000 n=10+10) name old allocs/op new allocs/op delta NewFrom-8 2.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10) Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/labels-cleanup
branch
from
67368ce
to
b80cd9a
Compare
|
/test |
tklauser
added
the
needs-backport/1.15
jibi
added
backport-pending/1.15
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in v1.15.0-rc.1
giorio94
added
the
backport-done/1.15
giorio94
removed
the
backport-pending/1.15
maintainer-s-little-helper
bot
moved this from Backport pending to v1.15
to Backport done to v1.15
in v1.15.0-rc.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.