Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: add ext_err for more callers of tail_call_internal() #30023

Merged

Conversation

julianwiedmann
Copy link
Member

As follow-on to #30001, improve some users of tail_call_internal() to pass an ext_err parameter.

When invoke_tailcall_if() expands into a tail-call, provide it with an
`ext_err` parameter so that the index of a missed tail-call can be
reported.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Allow tail_call_internal() to return the index of a missed tail-call.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Dec 21, 2023
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann marked this pull request as ready for review December 21, 2023 09:18
@julianwiedmann julianwiedmann requested a review from a team as a code owner December 21, 2023 09:18
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 10, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Jan 10, 2024
Merged via the queue into cilium:main with commit 7b5195e Jan 10, 2024
63 checks passed
@julianwiedmann julianwiedmann deleted the 1.16-bpf-tail-call-internal branch January 10, 2024 09:27
@julianwiedmann julianwiedmann added the backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants