Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Make TraceNotification configurable #30031

Closed

Conversation

EricMountain
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Makes TraceNotification configurable.

When enabled, trace notifications (send_trace_notify()) consume CPU in proportion to the volume of traffic on an instance. This makes the use of Hubble or other perf event consumers such as cilium monitor prohibitive on high-traffic nodes.

TraceNotification is only configurable via the agent API (e.g. cilium config TraceNotification=Disabled) and defaults to Enabled. This change makes this setting configurable at agent startup.

Fixes: #issue-number

TraceNotification is now configurable via `--trace-notification=true|false`.

@maintainer-s-little-helper
Copy link

Commit 48625b4 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 21, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Dec 21, 2023
@EricMountain
Copy link
Contributor Author

Superseded by #30063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. kind/community-contribution This was a contribution made by a community member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant