fqdn: skip ipcache insertion for names without fqdn selectors #30110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This small fix prevents allocating a local identity for IPs with names that are not selected by a toFQDN selector. Without this change, an identity is allocated for every IP included in an intercepted DNS response. For the (common) case where all DNS requests are proxied, this could potentially lead to a waste of resources and thus a performance regression. Previously (v1.14 and before), we did not allocate identities for un-selected IPs. That was inadvertently changed in cilium#29036. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
squeed
added
release-note/misc
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
jibi
added
backport-pending/1.15
giorio94
added
backport-done/1.15
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport done to v1.15
in v1.15.0-rc.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small fix prevents allocating a local identity for IPs with names that are not selected by a toFQDN selector. Without this change, an identity is allocated for every IP included in an intercepted DNS response. For the (common) case where all DNS requests are proxied, this could potentially lead to a waste of resources and thus a performance regression.
Previously (v1.14 and before), we did not allocate identities for un-selected IPs. That was inadvertently changed in #29036.