Correct Istio Integration Documentation for Cilium CLI Flag Usage #30152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jimmy Song <rootsongjc@gmail.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
qmonnet
requested changes
Jan 9, 2024
qmonnet
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
qmonnet
added
area/documentation
Signed-off-by: Jimmy Song <rootsongjc@gmail.com>
|
/test |
|
Commit 6be911f does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
|
Commit 92640e1 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
youngnick
approved these changes
Jan 11, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently followed the instructions in the Cilium Documentation for installing Istio alongside Cilium. The documentation suggests using the
--config bpf-lb-sock-hostns-only=trueCLI flag with Cilium to ensure compatibility with Istio. However, I noticed that the cilium CLI does not have a --config flag. Instead, it appears that the correct usage should be--set socketLB.hostNamespaceOnly=true.I know that the
ciliumCLI in the Cilium Agent has the--configflag, but in the context of this document, I think the one to use would be the Cilium Installation CLI.