Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.15] docs: add deprecation notice for enable-remote-node-identity for v1.15 #30208

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

tklauser
Copy link
Member

The enable-remote-node-identity agent flag was marked as deprecated for 1.15 in commit cf472ef ("daemon: Deprecate EnableRemoteNodeIdentity"). Add an upgrade note about the flag and the corresponding remoteNodeIdentity helm value being deprecated.

@tklauser tklauser added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/backports This PR provides functionality previously merged into master. release-note/misc This PR makes changes that have no direct user impact. backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. labels Jan 11, 2024
@tklauser tklauser requested a review from a team as a code owner January 11, 2024 14:33
@tklauser tklauser added the release-blocker/1.15 This issue will prevent the release of the next version of Cilium. label Jan 11, 2024
The enable-remote-node-identity agent flag was marked as deprecated for
1.15 in commit cf472ef ("daemon: Deprecate
EnableRemoteNodeIdentity"). Add an upgrade note about the flag and the
corresponding remoteNodeIdentity helm value being deprecated.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser force-pushed the pr/v1.15/tklauser/deprecate-remote-node-identity branch from d3d60c1 to f385885 Compare January 11, 2024 15:10
@tklauser tklauser requested review from a team and qmonnet and removed request for a team January 11, 2024 15:10
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this will avoid bugs like the one fixed there 🚢

@qmonnet
Copy link
Member

qmonnet commented Jan 11, 2024

/test

@tklauser
Copy link
Member Author

/test-backport-1.15

@nathanjsweet
Copy link
Member

Thanks @tklauser 🙏 !

@aanm aanm merged commit 56f586d into v1.15 Jan 15, 2024
200 of 202 checks passed
@aanm aanm deleted the pr/v1.15/tklauser/deprecate-remote-node-identity branch January 15, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. release-blocker/1.15 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants