[1.15] loader: fix obsolete XDP program removal #30224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
backport/1.15
|
/test-backport-1.15 |
rgo3
force-pushed
the
pr/rgo3/1.15-fix-obsolete-xdp-removal
branch
from
37259f5
to
1120831
Compare
|
/test-backport-1.15 |
ti-mo
approved these changes
Jan 12, 2024
|
@rgo3 this PR needs to be rebased since ipsec test is timing out and the timeout was increased already on the v1.15 branch. |
[ upstream commit ea7c375 ] This commit fixes a bug where `maybeUnloadObsoleteXDPPrograms()` removes XDP programs after a restart that are still in use and should remain in place. This can cause intermittent connectivity issues. The issue is that the kernel returns different values when it is queried for the attach mode of a netlink device compared to the values used when configuring the attach mode. E.g. when attaching with `XDPDriverMode` which evaluates to '4' in the input flags, querying it will return `XDP_ATTACHED_DRV` which evaluates to '1'. So when `maybeUnloadObsoleteXDPPrograms()` compares the queried values to the used input values there can be a mismatch which leads to cilium removing still needed XDP programs. This commit also changes the test, to be a suitable regression test for this fix. Previously the test was using `XDPGenericMode`. Unfortunately in this case the returned value from the kernel when querying netlink devices is `XDP_ATTACHED_SKB`, and both constants evaluate to '2' which is why this bug wasn't caught by the test in the first place. Fixes: #30132 Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
rgo3
force-pushed
the
pr/rgo3/1.15-fix-obsolete-xdp-removal
branch
from
1120831
to
2579c25
Compare
|
/test-backport-1.15 |
dylandreimerink
approved these changes
Jan 15, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual backport of #30163.