Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

policy: Fix MapState.Equals() #30233

Merged
merged 1 commit into from
Jan 12, 2024
Merged

policy: Fix MapState.Equals() #30233

merged 1 commit into from
Jan 12, 2024

Conversation

jrajahalme
Copy link
Member

Compare the entries of 'msA' and 'msB' rather than 'msB' against itself.

Simplify the body of the comparison function for readability.

Fixes: #28352

@jrajahalme
policy: Fix MapState.Equals()
d0b2a7f 
Compare the entries of 'msA' and 'msB' rather than 'msB' against itself.

Simplify the body of the comparison function for readability.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme added kind/bug/CI This is a bug in the testing code. needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Jan 12, 2024
@jrajahalme jrajahalme requested a review from a team as a code owner January 12, 2024 14:26
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in v1.15.0-rc.1 Jan 12, 2024
@jrajahalme jrajahalme mentioned this pull request Jan 12, 2024
Merged
@jrajahalme jrajahalme added the release-note/misc This PR makes changes that have no direct user impact. label Jan 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 12, 2024
@jrajahalme
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 12, 2024
@nathanjsweet nathanjsweet added this pull request to the merge queue Jan 12, 2024
Merged via the queue into cilium:main with commit 862fcd5 Jan 12, 2024
63 checks passed
@gandro gandro mentioned this pull request Jan 16, 2024
Merged
6 tasks
@gandro gandro added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Jan 16, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in v1.15.0-rc.1 Jan 16, 2024
@aanm aanm mentioned this pull request Jan 16, 2024
Merged
@gandro gandro added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 16, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.15 to Backport done to v1.15 in v1.15.0-rc.1 Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanjsweet nathanjsweet nathanjsweet approved these changes

Assignees
No one assigned
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
v1.15.0-rc.1
Backport done to v1.15
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrajahalme @nathanjsweet @gandro