-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loader: insert policy programs before attaching bpf entrypoints, enforce missed tail calls in ci-e2e #30248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-mo
added
sig/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
area/CI-improvement
Topic or proposal to improve the Continuous Integration workflow
release-note/ci
This PR makes changes to the CI.
labels
Jan 15, 2024
/test |
ti-mo
force-pushed
the
tb/enforce-missed-tail-calls
branch
2 times, most recently
from
January 15, 2024 11:53
2acc01e
to
e88fc22
Compare
/test |
See code comments for a detailed description of the problem. This commit installs policy programs before attaching tc/xdp hooks since doing things in the wrong order means dropping tail calls when handling traffic if the policy programs aren't inserted. Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/enforce-missed-tail-calls
branch
from
January 16, 2024 15:22
e88fc22
to
251be03
Compare
/test |
ti-mo
added
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
backport/author
The backport will be carried out by the author of the PR.
labels
Jan 17, 2024
ti-mo
added
the
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
label
Jan 17, 2024
This did 8 consecutive successful rounds of ci-e2e, so I'm calling it. No more missing tail calls (for now)! Marking this as ready for review. (Aside from hitting #30266 on a few occasions, of course.) |
brlbil
approved these changes
Jan 17, 2024
ti-mo
changed the title
conformance-e2e: enforce no missed tail calls occurring during tests
loader: insert policy programs before attaching bpf entrypoints, enforce missed tail calls in ci-e2e
Jan 17, 2024
ti-mo
added
release-note/bug
This PR fixes an issue in a previous release of Cilium.
sig/loader
Impacts the loading of BPF programs into the kernel.
and removed
release-note/ci
This PR makes changes to the CI.
labels
Jan 17, 2024
3 tasks
ti-mo
added
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
and removed
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
labels
Jan 18, 2024
2 tasks
ti-mo
added
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
and removed
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
labels
Jan 18, 2024
2 tasks
ti-mo
added
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
and removed
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
labels
Jan 18, 2024
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in v1.15.0-rc.1
Jan 18, 2024
github-actions
bot
added
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
and removed
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
labels
Jan 23, 2024
giorio94
added
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
and removed
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
labels
Jan 29, 2024
maintainer-s-little-helper
bot
moved this from Backport pending to v1.15
to Backport done to v1.15
in v1.15.0-rc.1
Jan 29, 2024
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI-improvement
Topic or proposal to improve the Continuous Integration workflow
backport/author
The backport will be carried out by the author of the PR.
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
sig/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
sig/loader
Impacts the loading of BPF programs into the kernel.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the early days of Cilium, we would miss tail calls in CI and not really monitor when or how these happened. Many improvements have been made in recent months to make these a thing of the past, but they were still occurring with host-fw enabled.
After the most recent round of fixes, most of these errors disappeared, but one bugbear remained. This PR addresses the final outstanding error in ordering prog array insertions:
Finally, strictly enforce no missed tail calls in all ci-e2e scenarios.
Fixes: #29476