[v1.13] ci/ipsec: Re-enable node-to-node-encryption check #30402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We disabled the check in commit 8646989 ("ci: In conn-disrupt-test action, disable node-to-node-encryption check") because we used to observe flakes. The issue has been fixed in v1.13 with commit 3a4deb3 ("node: Fix IP removal from ipset on node updates"). With the recent patch release v1.13.11 that contains the fix, we shouldn't hit the issue when downgrading to the closest patch release anymore, and we can now re-enable the check. Link: #29351 Link: #29898 Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
added
area/CI
maintainer-s-little-helper
bot
added
backport/1.13
|
/test-backport-1.13 |
julianwiedmann
approved these changes
Jan 24, 2024
qmonnet
added
the
ready-to-merge
squeed
approved these changes
Jan 24, 2024
|
😱
It's supposed to use the latest patch release (currently v1.13.11) though, right? Sounds like this is the version selection in the workflow itself where I messed up 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We disabled the check in commit 8646989 ("ci: In conn-disrupt-test action, disable node-to-node-encryption check") because we used to observe flakes.
The issue has been fixed in v1.13 with commit 3a4deb3 ("node: Fix IP removal from ipset on node updates"). With the recent patch release v1.13.11 that contains the fix, we shouldn't hit the issue when downgrading to the closest patch release anymore, and we can now re-enable the check.
Link: #29351
Link: #29898