Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.14] fix: Error using multiple allowRoutes namespaces in gateway #30551

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[v1.14] fix: Error using multiple allowRoutes namespaces in gateway #30551

merged 1 commit into from
Jan 31, 2024

Conversation

mhofstetter
Copy link
Member

@mhofstetter mhofstetter commented Jan 31, 2024 •
edited
Loading

Manual backport of #30100 (respective from #30550) (merge conflicts because of gateway api version v1 vs v1beta)

Fixes: #30085

Fix error when using multiple allowRoutes namespaces in gateway

@mhofstetter mhofstetter added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. area/servicemesh GH issues or PRs regarding servicemesh feature/k8s-gateway-api backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. labels Jan 31, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the kind/backports This PR provides functionality previously merged into master. label Jan 31, 2024
@chaunceyjiang @mhofstetter
Fix error when using multiple allowRoutes namespaces in gateway
ef2fd54 
Fixes: 30085

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/gateway-multiple-allowroutes-v1.14 branch from 5a4f87d to ef2fd54 Compare January 31, 2024 13:49
@mhofstetter
Copy link
Member Author

/test-backport-1.14

sayboras
sayboras approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@mhofstetter mhofstetter marked this pull request as ready for review January 31, 2024 14:34
@mhofstetter mhofstetter requested a review from a team as a code owner January 31, 2024 14:34
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 31, 2024
@sayboras sayboras merged commit 5d24879 into cilium:v1.14 Jan 31, 2024
58 of 59 checks passed
@michi-covalent michi-covalent mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@julianwiedmann julianwiedmann julianwiedmann approved these changes

Assignees
No one assigned
Labels
area/servicemesh GH issues or PRs regarding servicemesh backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. feature/k8s-gateway-api kind/backports This PR provides functionality previously merged into master. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
cilium v1.14.7
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mhofstetter @sayboras @julianwiedmann @chaunceyjiang