-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bpf_sock compilation for ipv6-only #30553
Conversation
Commit 946f9d3 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Commit 946f9d3 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
@alexferenets Please add a release note to your PR description (you removed it for some reason).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to fix a point Daniel mentioned, but otherwise, looks good to me.
@alexferenets Please address the comments, add a commit message (one that includes |
Commits 946f9d3, 89d33c5 do not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
4c0f897
to
03b73fa
Compare
03b73fa
to
6c35e23
Compare
70202fb
to
87168dc
Compare
/test |
@alexferenets - checkpatch is reporting a lint which should be fixed before this is merged: https://github.com/cilium/cilium/actions/runs/8111595771/job/22180953056?pr=30553 |
Agree, needs proper indent. Otherwise lgtm. |
@alexferenets could you update the indent to a tab? Otherwise its good to go. |
972c871
to
d5ce289
Compare
@borkmann can we merge it now? |
Otherwise, when started with --enable-ipv4=false --enable-ipv6=true I got level=error msg="Failed to compile bpf_sock.o: exit status 1" compiler-pid=2393 subsys=datapath-loader level=warning msg="/var/lib/cilium/bpf/bpf_sock.c:1094:10: error: implicit declaration of function '__sock4_health_fwd' [-Werror,-Wimplicit-function-declaration]" subsys=datapath-loader level=warning msg=" return __sock4_health_fwd(ctx);" subsys=datapath-loader level=warning msg=" ^" subsys=datapath-loader level=warning msg="/var/lib/cilium/bpf/bpf_sock.c:1094:10: note: did you mean '__sock6_health_fwd'?" subsys=datapath-loader level=warning msg="/var/lib/cilium/bpf/bpf_sock.c:1086:1: note: '__sock6_health_fwd' declared here" subsys=datapath-loader level=warning msg="__sock6_health_fwd(struct bpf_sock_addr *ctx __maybe_unused)" subsys=datapath-loader level=warning msg=^ subsys=datapath-loader level=warning msg="1 error generated." subsys=datapath-loader Signed-off-by: Alex Ferenets <al.ferenets@gmail.com>
d5ce289
to
8acf847
Compare
/test |
Otherwise, when started with
--enable-ipv4=false --enable-ipv6=true
I got