Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf, tests: Force v6 address into 'rodata' section #30610

Merged
merged 1 commit into from Feb 7, 2024
Merged

bpf, tests: Force v6 address into 'rodata' section #30610

merged 1 commit into from Feb 7, 2024

Conversation

learnitall
Copy link
Contributor

@learnitall learnitall commented Feb 2, 2024 •
edited

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

This commit forces v6 addresses in the pkgten.h header into the .rodata section of compiled ELF binaries. This prevents a possible mismatch between ELF and BTF for the locations of these v6 symbols.

Fix bug preventing consistent symbols between ELF and BTF for eBPF unit tests.

@learnitall
bpf, tests: Force v6 address into 'rodata' section
0383e3e 
This commit forces v6 addresses in the pkgten.h header into the .rodata
section of compiled ELF binaries. This prevents a possible mismatch
between ELF and BTF for the locations of these v6 symbols.

Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 2, 2024
@learnitall learnitall added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/ci This PR makes changes to the CI. labels Feb 2, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 2, 2024
@learnitall
Copy link
Contributor Author

I tagged this with release-note/ci, but if there is a label that is more appropriate, please feel free to change.

@learnitall learnitall marked this pull request as ready for review February 2, 2024 21:07
@learnitall learnitall requested a review from a team as a code owner February 2, 2024 21:07
@learnitall
Copy link
Contributor Author

Here's an example run that this fixes:

@learnitall
Copy link
Contributor Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 6, 2024
@ti-mo ti-mo added this pull request to the merge queue Feb 7, 2024
Merged via the queue into cilium:main with commit 39e65e9 Feb 7, 2024
63 checks passed
@giorio94 giorio94 added the needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch label Mar 12, 2024
@giorio94 giorio94 mentioned this pull request Mar 12, 2024
Merged
16 tasks
@giorio94 giorio94 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 12, 2024
@jibi jibi added needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 13, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Mar 16, 2024
@jrajahalme jrajahalme mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpash markpash markpash approved these changes

Assignees
No one assigned
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@learnitall @markpash @jibi @ti-mo @giorio94