New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Add default divisor
for GOMEMLIMIT
#30635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Feb 5, 2024
github-actions
bot
added
the
kind/community-contribution
This was a contribution made by a community member.
label
Feb 5, 2024
squeed
approved these changes
Feb 6, 2024
squeed
added
the
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
label
Feb 6, 2024
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Feb 6, 2024
squeed
added
the
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
label
Feb 6, 2024
youngnick
approved these changes
Feb 14, 2024
Anything that can be done to move this forward? This unfortunately breaks the ArgoCD ProgressiveSync feature since the daemonset is never able to get synchronized with the expected state. For anyone looking for a work-around in the mean time, you can add this to your argocd applicationSet / application:
|
/test |
Signed-off-by: Donnie McMahan <jmcmaha1@gmail.com>
tklauser
force-pushed
the
gomemlimit-divisor
branch
from
February 21, 2024 16:34
0a3d439
to
cec5ba9
Compare
/test |
tklauser
changed the title
Fixes #30634: Add default
helm: Add default Feb 21, 2024
divisor
for GOMEMLIMIT
divisor
for GOMEMLIMIT
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Feb 21, 2024
9 tasks
YutaroHayakawa
added
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
and removed
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
labels
Feb 27, 2024
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in 1.15.2
Feb 27, 2024
github-actions
bot
added
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
and removed
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
labels
Feb 28, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/helm
Impacts helm charts and user deployment experience
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
kind/community-contribution
This was a contribution made by a community member.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Fixes: #30634
This PR adds a
divisor
value forGOMEMLIMIT
to prevent Argo CD from flagging the application as out of sync.