Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Add default divisor for GOMEMLIMIT #30635

Merged
merged 1 commit into from Feb 21, 2024

Conversation

jdmcmahan
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.

Fixes: #30634

This PR adds a divisor value for GOMEMLIMIT to prevent Argo CD from flagging the application as out of sync.

Add default divisor for GOMEMLIMIT to satisfy Argo CD diff

@jdmcmahan jdmcmahan requested review from a team as code owners February 5, 2024 22:32
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 5, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Feb 5, 2024
@squeed squeed enabled auto-merge February 6, 2024 16:07
@squeed squeed added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Feb 6, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 6, 2024
@squeed squeed added the needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch label Feb 6, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.15.1 Feb 6, 2024
@michi-covalent michi-covalent added this to Needs backport from main in 1.15.2 Feb 14, 2024
@michi-covalent michi-covalent removed this from Needs backport from main in 1.15.1 Feb 14, 2024
@jwitko
Copy link

jwitko commented Feb 16, 2024

Anything that can be done to move this forward? This unfortunately breaks the ArgoCD ProgressiveSync feature since the daemonset is never able to get synchronized with the expected state.

For anyone looking for a work-around in the mean time, you can add this to your argocd applicationSet / application:

apiVersion: argoproj.io/v1alpha1
kind: Application
  name:
  namespace: 
spec:
  destination:
    namespace:
    server:
  ignoreDifferences:
    - group: apps
      jqPathExpressions:
        - >-
          .spec.template.spec.containers[] | select(.name ==
          "cilium-agent").env[] | select(.name ==
          "GOMEMLIMIT").valueFrom.resourceFieldRef.divisor
      kind: Daemonset
      name: cilium
      namespace: kube-system

@tklauser
Copy link
Member

/test

@tklauser tklauser added the area/helm Impacts helm charts and user deployment experience label Feb 21, 2024
Signed-off-by: Donnie McMahan <jmcmaha1@gmail.com>
@tklauser
Copy link
Member

/test

@tklauser tklauser changed the title Fixes #30634: Add default divisor for GOMEMLIMIT helm: Add default divisor for GOMEMLIMIT Feb 21, 2024
@squeed squeed added this pull request to the merge queue Feb 21, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 21, 2024
Merged via the queue into cilium:main with commit 7b4c0b0 Feb 21, 2024
62 checks passed
@YutaroHayakawa YutaroHayakawa mentioned this pull request Feb 27, 2024
9 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Feb 27, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in 1.15.2 Feb 27, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Feb 28, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.15 in 1.15.2 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Impacts helm charts and user deployment experience backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cilium perpetually out of sync in Argo CD due to missing divisor spec for GOMEMLIMIT
6 participants