envoy: Add support for exposing Envoy Admin API #30655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
sayboras
added
area/proxy
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
sayboras
force-pushed
the
tam/envoy-admin
branch
from
f23e869
to
d05be50
Compare
sayboras
commented
Feb 7, 2024
|
/test |
sayboras
requested review from
danehans,
nathanjsweet,
mhofstetter,
squeed and
learnitall
squeed
approved these changes
Feb 13, 2024
|
I'd really like the flag to say debug somewhere in there. Maybe |
sayboras
force-pushed
the
tam/envoy-admin
branch
3 times, most recently
from
8cbf205
to
d63b350
Compare
|
/test |
mhofstetter
requested changes
Feb 21, 2024
install/kubernetes/cilium/files/cilium-envoy/configmap/bootstrap-config.json
Outdated
Show resolved
Hide resolved
install/kubernetes/cilium/files/cilium-envoy/configmap/bootstrap-config.json
Outdated
Show resolved
Hide resolved
sayboras
force-pushed
the
tam/envoy-admin
branch
from
d63b350
to
0db09fe
Compare
|
/test |
sayboras
force-pushed
the
tam/envoy-admin
branch
from
0db09fe
to
1573ed8
Compare
|
/test |
mhofstetter
reviewed
Feb 23, 2024
mhofstetter
reviewed
Feb 23, 2024
sayboras
force-pushed
the
tam/envoy-admin
branch
from
1573ed8
to
c6a5bd1
Compare
|
/test |
sayboras
force-pushed
the
tam/envoy-admin
branch
from
c6a5bd1
to
91ae828
Compare
|
/test |
mhofstetter
reviewed
Mar 5, 2024
This is to support the capability to expose Envoy Admin API via new helm
flags envoy.debug.admin.{enabled,port} for both embedded and daemonset modes.
Fixes: #30647
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/envoy-admin
branch
from
91ae828
to
44ef5b1
Compare
mhofstetter
approved these changes
Mar 5, 2024
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support the capability to expose Envoy Admin API via new helm flags envoy.debug.admin.{enabled,port} for both embeded and daemonset modes.
Fixes: #30647